[android_webivew] Refactor polling checks in test code.

[android_webivew] Refactor polling checks in test code.

There really is no good reason to poll for something and not fail
in a test (otherwise we're just adding a sleep). I refactored our
test code to use new AwTestBase methods.

BUG=None
TEST=AndroidWebViewTests
// java-only change, trybots happy
NOTRY=true

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=245525

[mkosiba (inactive), 2014-01-17 12:11:04]

PTAL

[mnaganov (inactive), 2014-01-17 12:43:29]

LGTM with comments

Thanks for cleaning this up!

https://codereview.chromium.org/131743020/diff/1/android_webview/javatests/sr...
File
android_webview/javatests/src/org/chromium/android_webview/test/AwTestBase.java
(right):

https://codereview.chromium.org/131743020/diff/1/android_webview/javatests/sr...
android_webview/javatests/src/org/chromium/android_webview/test/AwTestBase.java:371:
Log.e("AwTestBase", "exception while polling", e);
Nit: please use "TAG" constant

https://codereview.chromium.org/131743020/diff/1/android_webview/javatests/sr...
android_webview/javatests/src/org/chromium/android_webview/test/AwTestBase.java:379:
* Similar to CriteriaHelper.pollForCriteria but runs the callable on the UI
thread.
Now as it doesn't return any value, it isn't "similar" anymore. I guess, we
should change to something like "Wraps CriteriaHelper.pollForCriteria to run the
callable on the UI thread".

https://codereview.chromium.org/131743020/diff/1/android_webview/javatests/sr...
File
android_webview/javatests/src/org/chromium/android_webview/test/GeolocationTest.java
(right):

https://codereview.chromium.org/131743020/diff/1/android_webview/javatests/sr...
android_webview/javatests/src/org/chromium/android_webview/test/GeolocationTest.java:24:
private static final long TEST_TIMEOUT_MS = 5000L;
Looks like these timeouts are not used anymore.

[mkosiba (inactive), 2014-01-17 13:14:26]

Thanks!

https://codereview.chromium.org/131743020/diff/1/android_webview/javatests/sr...
File
android_webview/javatests/src/org/chromium/android_webview/test/AwTestBase.java
(right):

https://codereview.chromium.org/131743020/diff/1/android_webview/javatests/sr...
android_webview/javatests/src/org/chromium/android_webview/test/AwTestBase.java:371:
Log.e("AwTestBase", "exception while polling", e);
On 2014/01/17 12:43:29, Mikhail Naganov (Cr) wrote:
> Nit: please use "TAG" constant

Done.

https://codereview.chromium.org/131743020/diff/1/android_webview/javatests/sr...
android_webview/javatests/src/org/chromium/android_webview/test/AwTestBase.java:379:
* Similar to CriteriaHelper.pollForCriteria but runs the callable on the UI
thread.
On 2014/01/17 12:43:29, Mikhail Naganov (Cr) wrote:
> Now as it doesn't return any value, it isn't "similar" anymore. I guess, we
> should change to something like "Wraps CriteriaHelper.pollForCriteria to run
the
> callable on the UI thread".

good find. I re-implemented pollOnUiThread using poll.

https://codereview.chromium.org/131743020/diff/1/android_webview/javatests/sr...
File
android_webview/javatests/src/org/chromium/android_webview/test/GeolocationTest.java
(right):

https://codereview.chromium.org/131743020/diff/1/android_webview/javatests/sr...
android_webview/javatests/src/org/chromium/android_webview/test/GeolocationTest.java:24:
private static final long TEST_TIMEOUT_MS = 5000L;
On 2014/01/17 12:43:29, Mikhail Naganov (Cr) wrote:
> Looks like these timeouts are not used anymore.

Done.

[commit-bot: I haz the power, 2014-01-17 16:08:03]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mkosiba@chromium.org/131743020/100001

[commit-bot: I haz the power, 2014-01-17 16:08:50]

Change committed as 245525