Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(47)

Unified Diff: android_webview/javatests/src/org/chromium/android_webview/test/AwContentsTest.java

Issue 131743020: [android_webivew] Refactor polling checks in test code. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: android_webview/javatests/src/org/chromium/android_webview/test/AwContentsTest.java
diff --git a/android_webview/javatests/src/org/chromium/android_webview/test/AwContentsTest.java b/android_webview/javatests/src/org/chromium/android_webview/test/AwContentsTest.java
index 9e4615daa759d8d1c0620a3364a519021f35dee5..70ab74248b2b263e84f04d9de5cdd9ffd58564d8 100644
--- a/android_webview/javatests/src/org/chromium/android_webview/test/AwContentsTest.java
+++ b/android_webview/javatests/src/org/chromium/android_webview/test/AwContentsTest.java
@@ -34,7 +34,7 @@ import java.util.concurrent.atomic.AtomicInteger;
* AwContents tests.
*/
public class AwContentsTest extends AwTestBase {
- public static class OnDownloadStartHelper extends CallbackHelper {
+ private static class OnDownloadStartHelper extends CallbackHelper {
String mUrl;
String mUserAgent;
String mContentDisposition;
@@ -163,12 +163,12 @@ public class AwContentsTest extends AwTestBase {
System.gc();
- assertTrue(pollOnUiThread(new Callable<Boolean>() {
+ pollOnUiThread(new Callable<Boolean>() {
@Override
public Boolean call() {
return AwContents.getNativeInstanceCount() <= MAX_IDLE_INSTANCES;
}
- }));
+ });
for (int i = 0; i < REPETITIONS; ++i) {
for (int j = 0; j < CONCURRENT_INSTANCES; ++j) {
AwTestContainerView view = createAwTestContainerViewOnMainSync(mContentsClient);
@@ -186,12 +186,12 @@ public class AwContentsTest extends AwTestBase {
System.gc();
- assertTrue(pollOnUiThread(new Callable<Boolean>() {
+ pollOnUiThread(new Callable<Boolean>() {
@Override
public Boolean call() {
return AwContents.getNativeInstanceCount() <= MAX_IDLE_INSTANCES;
}
- }));
+ });
}
private int callDocumentHasImagesSync(final AwContents awContents)
@@ -334,13 +334,13 @@ public class AwContentsTest extends AwTestBase {
getAwSettingsOnUiThread(awContents).setImagesEnabled(true);
loadUrlSync(awContents, mContentsClient.getOnPageFinishedHelper(), pageUrl);
- assertTrue(pollOnUiThread(new Callable<Boolean>() {
+ pollOnUiThread(new Callable<Boolean>() {
@Override
public Boolean call() {
return awContents.getFavicon() != null &&
!awContents.getFavicon().sameAs(defaultFavicon);
}
- }));
+ });
final Object originalFaviconSource = (new URL(faviconUrl)).getContent();
final Bitmap originalFavicon =

Powered by Google App Engine
This is Rietveld 408576698