[chromedriver] Don't apply device metrics overrides to app and extension pages.

chrome/test/chromedriver/chrome/chrome_desktop_impl.cc

 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/test/chromedriver/chrome/chrome_desktop_impl.h"
 
 #include "base/files/file_path.h"
 #include "base/logging.h"
 #include "base/posix/eintr_wrapper.h"
 #include "base/process/kill.h"
@@ skipping 83 matching lines @@
       LOG(WARNING) << "chromedriver automation extension directory: "
                    << extension_dir.value();
   }
 }
 
 Status ChromeDesktopImpl::WaitForPageToLoad(const std::string& url,
                                             const base::TimeDelta& timeout,
                                             scoped_ptr<WebView>* web_view) {
   base::TimeTicks deadline = base::TimeTicks::Now() + timeout;
   std::string id;
+  WebViewInfo::Type type = WebViewInfo::Type::kPage;
   while (base::TimeTicks::Now() < deadline) {
     WebViewsInfo views_info;
     Status status = devtools_http_client_->GetWebViewsInfo(&views_info);
     if (status.IsError())
       return status;
 
     for (size_t i = 0; i < views_info.GetSize(); ++i) {
-      if (views_info.Get(i).url.find(url) == 0) {
-        id = views_info.Get(i).id;
+      const WebViewInfo& view_info = views_info.Get(i);
+      if (view_info.url.find(url) == 0) {
+        id = view_info.id;
+        type = view_info.type;
         break;
       }
     }
     if (!id.empty())
       break;
     base::PlatformThread::Sleep(base::TimeDelta::FromMilliseconds(100));
   }
   if (id.empty())
     return Status(kUnknownError, "page could not be found: " + url);
 
+  const DeviceMetrics* device_metrics = devtools_http_client_->device_metrics();
+  if (type == WebViewInfo::Type::kApp ||
+      type == WebViewInfo::Type::kBackgroundPage) {
+    // Apps and extensions don't work on Android, so it doesn't make sense to
+    // provide override device metrics in mobile emulation mode, and can also
+    // potentially crash the renderer, for more details see:
+    // https://code.google.com/p/chromedriver/issues/detail?id=1205
+    device_metrics = nullptr;
+  }
   scoped_ptr<WebView> web_view_tmp(
       new WebViewImpl(id,
                       devtools_http_client_->browser_info(),
                       devtools_http_client_->CreateClient(id),
-                      devtools_http_client_->device_metrics()));
+                      device_metrics));
   Status status = web_view_tmp->ConnectIfNecessary();
   if (status.IsError())
     return status;
 
   status = web_view_tmp->WaitForPendingNavigations(
       std::string(), deadline - base::TimeTicks::Now(), false);
   if (status.IsOk())
     *web_view = web_view_tmp.Pass();
   return status;
 }
@@ skipping 40 matching lines @@
   // we're using a temporary user data directory, we're going to delete
   // the temporary directory anyway, so just send SIGKILL immediately.
   if (!KillProcess(process_, !user_data_dir_.IsValid()))
     return Status(kUnknownError, "cannot kill Chrome");
   return Status(kOk);
 }
 
 const base::CommandLine& ChromeDesktopImpl::command() const {
   return command_;
 }