Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(158)

Issue 1317093007: ipc: Make a new class PlaceholderBrokerableAttachment. (Closed)

Created:
5 years, 3 months ago by erikchen
Modified:
5 years, 3 months ago
Reviewers:
Tom Sepez
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

ipc: Make a new class PlaceholderBrokerableAttachment. Instances of this class need to be replaced before the message can be dispatched. This mechanism is a lot cleaner than the previous mechanism, which had an "unbrokered" state for every type of BrokerableAttachment, which had to be mutated before being dispatched. BUG=493414 Committed: https://crrev.com/87351da8166440ba0978a3c74701aa8242b72295 Cr-Commit-Position: refs/heads/master@{#348952}

Patch Set 1 : Diff against top of tree. #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : Rebase to pick up compile fixes. #

Patch Set 6 : Rebase. #

Patch Set 7 : Rebase errors. #

Patch Set 8 : More rebase errors. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+116 lines, -78 lines) Patch
M ipc/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
M ipc/attachment_broker_privileged_win.cc View 2 chunks +5 lines, -1 line 0 comments Download
M ipc/attachment_broker_unprivileged_win.cc View 1 chunk +5 lines, -1 line 0 comments Download
M ipc/brokerable_attachment.h View 1 2 3 4 5 2 chunks +7 lines, -11 lines 0 comments Download
M ipc/brokerable_attachment.cc View 1 2 3 1 chunk +11 lines, -12 lines 0 comments Download
M ipc/handle_attachment_win.h View 1 chunk +0 lines, -1 line 0 comments Download
M ipc/handle_attachment_win.cc View 2 chunks +2 lines, -15 lines 0 comments Download
M ipc/ipc.gypi View 1 chunk +2 lines, -0 lines 0 comments Download
M ipc/ipc_channel_reader.cc View 1 2 3 4 5 3 chunks +6 lines, -5 lines 0 comments Download
M ipc/ipc_channel_reader_unittest.cc View 5 chunks +9 lines, -16 lines 0 comments Download
M ipc/ipc_message.h View 1 2 3 4 5 1 chunk +5 lines, -0 lines 0 comments Download
M ipc/ipc_message.cc View 1 2 3 4 5 2 chunks +8 lines, -0 lines 0 comments Download
M ipc/ipc_message_attachment_set.h View 1 chunk +5 lines, -2 lines 0 comments Download
M ipc/ipc_message_attachment_set.cc View 1 chunk +17 lines, -9 lines 0 comments Download
A ipc/placeholder_brokerable_attachment.h View 1 chunk +28 lines, -0 lines 0 comments Download
A + ipc/placeholder_brokerable_attachment.cc View 6 7 1 chunk +4 lines, -5 lines 0 comments Download

Messages

Total messages: 70 (36 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1317093007/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1317093007/1
5 years, 3 months ago (2015-08-28 21:16:14 UTC) #2
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: android_chromium_gn_compile_dbg on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromium_gn_compile_dbg/builds/109297) android_chromium_gn_compile_rel on ...
5 years, 3 months ago (2015-08-28 21:22:16 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1317093007/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1317093007/20001
5 years, 3 months ago (2015-08-28 21:29:39 UTC) #6
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/100340) win_chromium_x64_rel_ng on ...
5 years, 3 months ago (2015-08-28 22:04:41 UTC) #8
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1317093007/50025 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1317093007/50025
5 years, 3 months ago (2015-08-28 23:01:12 UTC) #10
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: win_chromium_compile_dbg_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_compile_dbg_ng/builds/76913) win_chromium_x64_rel_ng on ...
5 years, 3 months ago (2015-08-28 23:35:25 UTC) #12
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1317093007/70001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1317093007/70001
5 years, 3 months ago (2015-08-29 00:26:35 UTC) #14
erikchen
5 years, 3 months ago (2015-08-29 00:47:54 UTC) #16
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_chromium_clobber_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_clobber_rel_ng/builds/63744)
5 years, 3 months ago (2015-08-29 01:06:41 UTC) #18
Tom Sepez
lgtm
5 years, 3 months ago (2015-09-10 16:05:14 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1317093007/90001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1317093007/90001
5 years, 3 months ago (2015-09-11 20:07:15 UTC) #22
commit-bot: I haz the power
Try jobs failed on following builders: ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator_ninja/builds/68282)
5 years, 3 months ago (2015-09-11 20:16:42 UTC) #24
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1317093007/110001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1317093007/110001
5 years, 3 months ago (2015-09-11 21:17:44 UTC) #27
commit-bot: I haz the power
Try jobs failed on following builders: cast_shell_android on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_android/builds/53183) ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED, ...
5 years, 3 months ago (2015-09-11 21:31:50 UTC) #29
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1317093007/130001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1317093007/130001
5 years, 3 months ago (2015-09-11 21:35:16 UTC) #32
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/112560)
5 years, 3 months ago (2015-09-11 21:53:56 UTC) #34
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1317093007/130001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1317093007/130001
5 years, 3 months ago (2015-09-11 21:57:19 UTC) #36
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_ozone_rel_ng/builds/61892)
5 years, 3 months ago (2015-09-11 22:14:33 UTC) #38
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1317093007/130001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1317093007/130001
5 years, 3 months ago (2015-09-11 22:31:47 UTC) #40
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_gn_dbg on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_gn_dbg/builds/115130)
5 years, 3 months ago (2015-09-11 22:57:59 UTC) #42
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1317093007/130001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1317093007/130001
5 years, 3 months ago (2015-09-12 01:09:03 UTC) #44
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_compile_dbg_32_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_compile_dbg_32_ng/builds/96590)
5 years, 3 months ago (2015-09-12 01:51:57 UTC) #46
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1317093007/130001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1317093007/130001
5 years, 3 months ago (2015-09-12 17:17:48 UTC) #48
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_asan_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_asan_rel_ng/builds/52192) linux_chromium_chromeos_compile_dbg_ng on tryserver.chromium.linux (JOB_FAILED, ...
5 years, 3 months ago (2015-09-12 20:19:30 UTC) #50
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1317093007/130001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1317093007/130001
5 years, 3 months ago (2015-09-13 17:51:04 UTC) #52
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_clobber_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_clobber_rel_ng/builds/69220)
5 years, 3 months ago (2015-09-13 23:52:55 UTC) #54
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1317093007/130001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1317093007/130001
5 years, 3 months ago (2015-09-14 17:11:45 UTC) #56
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/99406) linux_chromium_clobber_rel_ng on tryserver.chromium.linux (JOB_FAILED, ...
5 years, 3 months ago (2015-09-14 17:23:06 UTC) #58
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1317093007/170001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1317093007/170001
5 years, 3 months ago (2015-09-14 19:22:30 UTC) #61
commit-bot: I haz the power
Try jobs failed on following builders: win8_chromium_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_ng/builds/40409) win_chromium_compile_dbg_ng on tryserver.chromium.win (JOB_FAILED, ...
5 years, 3 months ago (2015-09-14 19:59:01 UTC) #63
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1317093007/130001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1317093007/130001
5 years, 3 months ago (2015-09-15 17:32:41 UTC) #67
commit-bot: I haz the power
Committed patchset #8 (id:130001)
5 years, 3 months ago (2015-09-15 19:11:19 UTC) #68
commit-bot: I haz the power
Patchset 8 (id:??) landed as https://crrev.com/87351da8166440ba0978a3c74701aa8242b72295 Cr-Commit-Position: refs/heads/master@{#348952}
5 years, 3 months ago (2015-09-15 19:12:13 UTC) #69
commit-bot: I haz the power
5 years, 3 months ago (2015-09-23 12:47:52 UTC) #70
Message was sent while issue was closed.
Patchset 8 (id:??) landed as
https://crrev.com/87351da8166440ba0978a3c74701aa8242b72295
Cr-Commit-Position: refs/heads/master@{#348952}

Powered by Google App Engine
This is Rietveld 408576698