Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(466)

Unified Diff: ipc/handle_attachment_win.cc

Issue 1317093007: ipc: Make a new class PlaceholderBrokerableAttachment. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: More rebase errors. Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ipc/handle_attachment_win.h ('k') | ipc/ipc.gypi » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ipc/handle_attachment_win.cc
diff --git a/ipc/handle_attachment_win.cc b/ipc/handle_attachment_win.cc
index 50e3e6dab24310c5bba54d5f44cfa42cb436630e..b7f43734b5bc7500af56629432ed5ae3da547aec 100644
--- a/ipc/handle_attachment_win.cc
+++ b/ipc/handle_attachment_win.cc
@@ -14,13 +14,13 @@ HandleAttachmentWin::HandleAttachmentWin(const HANDLE& handle,
: handle_(handle), permissions_(permissions) {}
HandleAttachmentWin::HandleAttachmentWin(const WireFormat& wire_format)
- : BrokerableAttachment(wire_format.attachment_id, false),
+ : BrokerableAttachment(wire_format.attachment_id),
handle_(LongToHandle(wire_format.handle)),
permissions_(wire_format.permissions) {}
HandleAttachmentWin::HandleAttachmentWin(
const BrokerableAttachment::AttachmentId& id)
- : BrokerableAttachment(id, true),
+ : BrokerableAttachment(id),
handle_(INVALID_HANDLE_VALUE),
permissions_(HandleWin::INVALID) {}
@@ -32,19 +32,6 @@ HandleAttachmentWin::BrokerableType HandleAttachmentWin::GetBrokerableType()
return WIN_HANDLE;
}
-void HandleAttachmentWin::PopulateWithAttachment(
- const BrokerableAttachment* attachment) {
- DCHECK(NeedsBrokering());
- DCHECK(!attachment->NeedsBrokering());
- DCHECK(GetIdentifier() == attachment->GetIdentifier());
- DCHECK_EQ(GetBrokerableType(), attachment->GetBrokerableType());
-
- const HandleAttachmentWin* handle_attachment =
- static_cast<const HandleAttachmentWin*>(attachment);
- handle_ = handle_attachment->handle_;
- SetNeedsBrokering(false);
-}
-
HandleAttachmentWin::WireFormat HandleAttachmentWin::GetWireFormat(
const base::ProcessId& destination) const {
WireFormat format;
« no previous file with comments | « ipc/handle_attachment_win.h ('k') | ipc/ipc.gypi » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698