Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1268)

Issue 1317063003: Reland of MSE: Verify MediaLog events created by existing MP4 unit tests (Closed)

Created:
5 years, 3 months ago by wolenetz
Modified:
5 years, 3 months ago
Reviewers:
chcunningham, xhwang
CC:
chromium-reviews, feature-media-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@more_mockmedialog_testing_webm
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland of MSE: Verify MediaLog events created by existing MP4 unit tests (patchset #1 id:1 of https://codereview.chromium.org/1306783003/ ) Reason for revert: Relanding this now that the fixed prerequisite CL (https://codereview.chromium.org/1306923004/) has landed. Original issue's description: > Revert of MSE: Verify MediaLog events created by existing MP4 unit tests (patchset #2 id:20001 of https://codereview.chromium.org/1300013002/ ) > > Reason for revert: > Prerequisite CL (https://codereview.chromium.org/1300943002/) is breaking windows bots (http://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%28dbg%29%281%29/builds/41148), so reverting both this and it to unblock tree. > > Original issue's description: > > MSE: Verify MediaLog events created by existing MP4 unit tests > > > > Similar to previous changes r342861 and > > https://codereview.chromium.org/1300943002/, this change updates media > > unit tests to provide a StrictMock<MockMediaLog> to verify MediaLog > > events produced with existing MSE MP4 unit tests. While log message > > maintenance burden is increased, helpers are used to reduce that burden > > while gaining improved resilience against logging regression. > > > > This CL does not verify all possible MSE MP4 parser MEDIA_LOGs, just > > those that are emitted by existing unit tests. > > > > TEST=no regression > > > > Committed: https://crrev.com/194a2651ece516dc91fa0da9aa1675afd307e36e > > Cr-Commit-Position: refs/heads/master@{#345183} > > TBR=xhwang@chromium.org,chcunningham@chromium.org > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > > Committed: https://crrev.com/61053d4768697c51bad15d7a9bdffa98c591bb7e > Cr-Commit-Position: refs/heads/master@{#345205} TBR=xhwang@chromium.org,chcunningham@chromium.org BUG=524597 Committed: https://crrev.com/e36716b881725c20eb593b4151341f1053400bf2 Cr-Commit-Position: refs/heads/master@{#345775}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+125 lines, -28 lines) Patch
M media/formats/mp4/aac_unittest.cc View 9 chunks +33 lines, -2 lines 0 comments Download
M media/formats/mp4/box_reader_unittest.cc View 7 chunks +34 lines, -22 lines 0 comments Download
M media/formats/mp4/mp4_stream_parser_unittest.cc View 10 chunks +44 lines, -2 lines 0 comments Download
M media/formats/mp4/track_run_iterator_unittest.cc View 4 chunks +14 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
wolenetz
Created Reland of MSE: Verify MediaLog events created by existing MP4 unit tests
5 years, 3 months ago (2015-08-27 02:09:11 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1317063003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1317063003/1
5 years, 3 months ago (2015-08-27 02:09:36 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1317063003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1317063003/1
5 years, 3 months ago (2015-08-27 02:14:01 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-08-27 02:44:22 UTC) #7
commit-bot: I haz the power
5 years, 3 months ago (2015-08-27 02:45:02 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e36716b881725c20eb593b4151341f1053400bf2
Cr-Commit-Position: refs/heads/master@{#345775}

Powered by Google App Engine
This is Rietveld 408576698