Source/core/svg/SVGTextContentElement.cpp - Issue 1317053004: Make VisiblePosition constructor private

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/svg/SVGTextContentElement.cpp

Issue 1317053004: Make VisiblePosition constructor private (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: 2015-09-01T18:48:19 Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/svg/SVGTextContentElement.cpp

diff --git a/Source/core/svg/SVGTextContentElement.cpp b/Source/core/svg/SVGTextContentElement.cpp

index 59f3c3b10c47e3130007f72625b746f8a543dc55..13c1283d25a129a78ef19ffb3ef1eb35f79a80c9 100644

--- a/Source/core/svg/SVGTextContentElement.cpp

+++ b/Source/core/svg/SVGTextContentElement.cpp

@@ -188,7 +188,7 @@ void SVGTextContentElement::selectSubString(unsigned charnum, unsigned nchars, E

ASSERT(document().frame());

// Find selection start

- VisiblePosition start(firstPositionInNode(const_cast<SVGTextContentElement*>(this)));

+ VisiblePosition start = createVisiblePosition(firstPositionInNode(const_cast<SVGTextContentElement*>(this)));

for (unsigned i = 0; i < charnum; ++i)

start = nextPositionOf(start);