Source/core/html/HTMLTextFormControlElementTest.cpp - Issue 1317053004: Make VisiblePosition constructor private

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/html/HTMLTextFormControlElementTest.cpp

Issue 1317053004: Make VisiblePosition constructor private (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: 2015-09-01T18:48:19 Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/html/HTMLTextFormControlElementTest.cpp

diff --git a/Source/core/html/HTMLTextFormControlElementTest.cpp b/Source/core/html/HTMLTextFormControlElementTest.cpp

index d27b23ee936a9420c1041562f2bc53714d31d078..935452d5c119cb714a316ed702b34160fb1b8ca0 100644

--- a/Source/core/html/HTMLTextFormControlElementTest.cpp

+++ b/Source/core/html/HTMLTextFormControlElementTest.cpp

@@ -136,9 +136,9 @@ typedef VisiblePosition(*VisblePositionFunction)(const VisiblePosition&);

void testFunctionEquivalence(const Position& position, PositionFunction positionFunction, VisblePositionFunction visibleFunction)

{

- VisiblePosition visiblePosition(position);

+ VisiblePosition visiblePosition = createVisiblePosition(position);

VisiblePosition expected = visibleFunction(visiblePosition);

- VisiblePosition actual = VisiblePosition(positionFunction(position));

+ VisiblePosition actual = createVisiblePosition(positionFunction(position));

EXPECT_EQ(expected.deepEquivalent(), actual.deepEquivalent());

}