Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(47)

Unified Diff: Source/core/editing/commands/InsertTextCommand.cpp

Issue 1317053004: Make VisiblePosition constructor private (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: 2015-09-01T18:48:19 Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/editing/commands/InsertTextCommand.cpp
diff --git a/Source/core/editing/commands/InsertTextCommand.cpp b/Source/core/editing/commands/InsertTextCommand.cpp
index f750b1abbce6bf56a07495605c7abfd117d69d9d..75792cc2b2ef7819855130b1d758f732f5b21f10 100644
--- a/Source/core/editing/commands/InsertTextCommand.cpp
+++ b/Source/core/editing/commands/InsertTextCommand.cpp
@@ -159,7 +159,7 @@ void InsertTextCommand::doApply()
Position downstream(mostForwardCaretPosition(startPosition));
if (lineBreakExistsAtPosition(downstream)) {
// FIXME: This doesn't handle placeholders at the end of anonymous blocks.
- VisiblePosition caret(startPosition);
+ VisiblePosition caret = createVisiblePosition(startPosition);
if (isEndOfBlock(caret) && isStartOfParagraph(caret))
placeholder = downstream;
// Don't remove the placeholder yet, otherwise the block we're inserting into would collapse before
@@ -233,7 +233,7 @@ void InsertTextCommand::doApply()
Position InsertTextCommand::insertTab(const Position& pos)
{
- Position insertPos = VisiblePosition(pos).deepEquivalent();
+ Position insertPos = createVisiblePosition(pos).deepEquivalent();
if (insertPos.isNull())
return pos;

Powered by Google App Engine
This is Rietveld 408576698