Make VisiblePosition constructor private

Source/core/editing/commands/InsertTextCommand.cpp

 /*
  * Copyright (C) 2005 Apple Computer, Inc.  All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2. Redistributions in binary form must reproduce the above copyright
  *    notice, this list of conditions and the following disclaimer in the
@@ skipping 141 matching lines @@
     Position startPosition(endingSelection().start());
 
     Position placeholder;
     // We want to remove preserved newlines and brs that will collapse (and thus become unnecessary) when content
     // is inserted just before them.
     // FIXME: We shouldn't really have to do this, but removing placeholders is a workaround for 9661.
     // If the caret is just before a placeholder, downstream will normalize the caret to it.
     Position downstream(mostForwardCaretPosition(startPosition));
     if (lineBreakExistsAtPosition(downstream)) {
         // FIXME: This doesn't handle placeholders at the end of anonymous blocks.
-        VisiblePosition caret(startPosition);
+        VisiblePosition caret = createVisiblePosition(startPosition);
         if (isEndOfBlock(caret) && isStartOfParagraph(caret))
             placeholder = downstream;
         // Don't remove the placeholder yet, otherwise the block we're inserting into would collapse before
         // we get a chance to insert into it.  We check for a placeholder now, though, because doing so requires
         // the creation of a VisiblePosition, and if we did that post-insertion it would force a layout.
     }
 
     // Insert the character at the leftmost candidate.
     startPosition = mostBackwardCaretPosition(startPosition);
 
@@ skipping 53 matching lines @@
         if (!typingStyle->isEmpty())
             applyStyle(typingStyle.get());
     }
 
     if (!m_selectInsertedText)
         setEndingSelection(VisibleSelection(endingSelection().end(), endingSelection().affinity(), endingSelection().isDirectional()));
 }
 
 Position InsertTextCommand::insertTab(const Position& pos)
 {
-    Position insertPos = VisiblePosition(pos).deepEquivalent();
+    Position insertPos = createVisiblePosition(pos).deepEquivalent();
     if (insertPos.isNull())
         return pos;
 
     Node* node = insertPos.computeContainerNode();
     unsigned offset = node->isTextNode() ? insertPos.offsetInContainerNode() : 0;
 
     // keep tabs coalesced in tab span
     if (isTabHTMLSpanElementTextNode(node)) {
         RefPtrWillBeRawPtr<Text> textNode = toText(node);
         insertTextIntoNode(textNode, offset, "\t");
@@ skipping 19 matching lines @@
                 splitTextNode(textNode, offset);
             insertNodeBefore(spanElement, textNode.release());
         }
     }
 
     // return the position following the new tab
     return lastPositionInNode(spanElement.get());
 }
 
 }