Issue 1317023003: win: Pass WINHTTP_FLAG_SECURE when necessary

Issue 1317023003: win: Pass WINHTTP_FLAG_SECURE when necessary (Closed)

Created:
5 years, 3 months ago by scottmg

Modified:
5 years, 3 months ago

Reviewers:
Mark Mentovai

CC:
crashpad-dev_chromium.org

Base URL:
https://chromium.googlesource.com/crashpad/crashpad@handler-exe-with-uuid

Target Ref:
refs/heads/master

Project:
crashpad

Visibility:
Public.

More Reviews

Description

win: Pass WINHTTP_FLAG_SECURE when necessary Otherwise the server drops us when connecting to an https endpoint, and WinHttpReceiveResponse fails with an obscure error. R=mark@chromium.org BUG=crashpad:1 Committed: https://chromium.googlesource.com/crashpad/crashpad/+/78bba8808b9b73fec3c2237c8edc3e75e6823816

Patch Set 4 : dcheck nScheme #

Created: 5 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+11 lines, -8 lines)			Patch
	M	util/net/http_transport_win.cc	View	1 2 3	2 chunks	+11 lines, -8 lines	0 comments	Download

Depends on Patchset:

Issue 1311003003 Patch 100001

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Mark Mentovai

LGTM https://codereview.chromium.org/1317023003/diff/1/util/net/http_transport_win.cc File util/net/http_transport_win.cc (right): https://codereview.chromium.org/1317023003/diff/1/util/net/http_transport_win.cc#newcode122 util/net/http_transport_win.cc:122: std::wstring host_name(url_components.lpszHostName, DCHECK that nScheme is INTERNET_SCHEME_HTTP or ...

5 years, 3 months ago (2015-08-26 22:17:38 UTC) #2

scottmg

Committed patchset #4 (id:60001) manually as 78bba8808b9b73fec3c2237c8edc3e75e6823816 (presubmit successful).

5 years, 3 months ago (2015-08-31 20:28:24 UTC) #3

scottmg

5 years, 3 months ago (2015-08-31 20:28:31 UTC) #4

Message was sent while issue was closed.

https://codereview.chromium.org/1317023003/diff/1/util/net/http_transport_win.cc
File util/net/http_transport_win.cc (right):

https://codereview.chromium.org/1317023003/diff/1/util/net/http_transport_win...
util/net/http_transport_win.cc:122: std::wstring
host_name(url_components.lpszHostName,
On 2015/08/26 22:17:38, Mark Mentovai - August is over wrote:
> DCHECK that nScheme is INTERNET_SCHEME_HTTP or INTERNET_SCHEME_HTTPS.

Done.

Expand Messages | Collapse Messages