win: Pass WINHTTP_FLAG_SECURE when necessary

util/net/http_transport_win.cc

 // Copyright 2015 The Crashpad Authors. All rights reserved.
 //
 // Licensed under the Apache License, Version 2.0 (the "License");
 // you may not use this file except in compliance with the License.
 // You may obtain a copy of the License at
 //
 //     http://www.apache.org/licenses/LICENSE-2.0
 //
 // Unless required by applicable law or agreed to in writing, software
 // distributed under the License is distributed on an "AS IS" BASIS,
@@ skipping 101 matching lines @@
   url_components.dwStructSize = sizeof(URL_COMPONENTS);
   url_components.dwHostNameLength = 1;
   url_components.dwUrlPathLength = 1;
   url_components.dwExtraInfoLength = 1;
   std::wstring url_wide(base::UTF8ToUTF16(url()));
   if (!WinHttpCrackUrl(
           url_wide.c_str(), 0, ICU_REJECT_USERPWD, &url_components)) {
     LogErrorWinHttpMessage("WinHttpCrackUrl");
     return false;
   }
   std::wstring host_name(url_components.lpszHostName,

[Mark Mentovai, 2015/08/26 22:17:38]

DCHECK that nScheme is INTERNET_SCHEME_HTTP or INTERNET_SCHEME_HTTPS.

[scottmg, 2015/08/31 20:28:31]

Done.

                          url_components.dwHostNameLength);
   std::wstring url_path(url_components.lpszUrlPath,
                         url_components.dwUrlPathLength);
   std::wstring extra_info(url_components.lpszExtraInfo,
                           url_components.dwExtraInfoLength);
 
   ScopedHINTERNET connect(WinHttpConnect(
       session.get(), host_name.c_str(), url_components.nPort, 0));
   if (!connect.get()) {
     LogErrorWinHttpMessage("WinHttpConnect");
     return false;
   }
 
-  ScopedHINTERNET request(
-      WinHttpOpenRequest(connect.get(),
-                         base::UTF8ToUTF16(method()).c_str(),
-                         url_path.c_str(),
-                         nullptr,
-                         WINHTTP_NO_REFERER,
-                         WINHTTP_DEFAULT_ACCEPT_TYPES,
-                         0));
+  ScopedHINTERNET request(WinHttpOpenRequest(
+      connect.get(),
+      base::UTF8ToUTF16(method()).c_str(),
+      url_path.c_str(),
+      nullptr,
+      WINHTTP_NO_REFERER,
+      WINHTTP_DEFAULT_ACCEPT_TYPES,
+      url_components.nScheme == INTERNET_SCHEME_HTTPS ? WINHTTP_FLAG_SECURE
+                                                      : 0));
   if (!request.get()) {
     LogErrorWinHttpMessage("WinHttpOpenRequest");
     return false;
   }
 
   // Add headers to the request.
   for (const auto& pair : headers()) {
     std::wstring header_string =
         base::UTF8ToUTF16(pair.first) + L": " + base::UTF8ToUTF16(pair.second);
     if (!WinHttpAddRequestHeaders(
@@ skipping 81 matching lines @@
 }
 
 }  // namespace
 
 // static
 scoped_ptr<HTTPTransport> HTTPTransport::Create() {
   return scoped_ptr<HTTPTransportWin>(new HTTPTransportWin);
 }
 
 }  // namespace crashpad