Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Issue 1316973002: Pass WebPushError::ErrorTypePermissionDenied when appropriate. (Closed)

Created:
5 years, 3 months ago by Peter Beverloo
Modified:
5 years, 3 months ago
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, johnme+watch_chromium.org, jam, mvanouwerkerk+watch_chromium.org, darin-cc_chromium.org, mkwst+moarreviews-renderer_chromium.org, peter+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Pass WebPushError::ErrorTypePermissionDenied when appropriate. This will allow Blink to trigger the appropriate DOMException. This CL is part of a three-sided patch: [1] https://codereview.chromium.org/1314493008/ [2] This CL. [3] https://codereview.chromium.org/1313493003/ BUG=522206 Committed: https://crrev.com/13aeb042a708ad87c721b81d1a580880d8bfceef Cr-Commit-Position: refs/heads/master@{#346634}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -5 lines) Patch
M chrome/browser/push_messaging/push_messaging_browsertest.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M content/child/push_messaging/push_provider.cc View 1 chunk +6 lines, -1 line 0 comments Download
M content/renderer/push_messaging/push_messaging_dispatcher.cc View 1 chunk +6 lines, -1 line 0 comments Download

Messages

Total messages: 9 (3 generated)
Peter Beverloo
PTAL
5 years, 3 months ago (2015-08-26 14:37:55 UTC) #2
johnme
lgtm
5 years, 3 months ago (2015-08-27 16:11:08 UTC) #4
Michael van Ouwerkerk
lgtm
5 years, 3 months ago (2015-09-01 10:01:48 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1316973002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1316973002/1
5 years, 3 months ago (2015-09-01 11:35:12 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-09-01 12:40:35 UTC) #8
commit-bot: I haz the power
5 years, 3 months ago (2015-09-01 12:41:05 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/13aeb042a708ad87c721b81d1a580880d8bfceef
Cr-Commit-Position: refs/heads/master@{#346634}

Powered by Google App Engine
This is Rietveld 408576698