content/child/push_messaging/push_provider.cc - Issue 1316973002: Pass WebPushError::ErrorTypePermissionDenied when appropriate.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/child/push_messaging/push_provider.cc

Issue 1316973002: Pass WebPushError::ErrorTypePermissionDenied when appropriate. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/push_messaging/push_messaging_browsertest.cc ('k') | content/renderer/push_messaging/push_messaging_dispatcher.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/child/push_messaging/push_provider.cc

diff --git a/content/child/push_messaging/push_provider.cc b/content/child/push_messaging/push_provider.cc

index d503f507dd4c02b7413c1c2b54e155d4a47a69ad..089460172edf7b41f73932e9d539d6080d11893a 100644

--- a/content/child/push_messaging/push_provider.cc

+++ b/content/child/push_messaging/push_provider.cc

@@ -168,8 +168,13 @@ void PushProvider::OnSubscribeFromWorkerError(int request_id,

if (!callbacks)

return;

+ blink::WebPushError::ErrorType error_type =

+ status == PUSH_REGISTRATION_STATUS_PERMISSION_DENIED

+ ? blink::WebPushError::ErrorTypePermissionDenied

+ : blink::WebPushError::ErrorTypeAbort;

callbacks->onError(blink::WebPushError(

- blink::WebPushError::ErrorTypeAbort,

+ error_type,

blink::WebString::fromUTF8(PushRegistrationStatusToString(status))));

subscription_callbacks_.Remove(request_id);