Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(162)

Issue 1316693002: Remove left-overs of PushSubscription.curve25519dh (Closed)

Created:
5 years, 4 months ago by Peter Beverloo
Modified:
5 years, 3 months ago
CC:
blink-reviews, michaeln, jsbell+serviceworker_chromium.org, kenjibaheux+watch_chromium.org, tzik, johnme+watch_chromium.org, serviceworker-reviews, nhiroki, falken, mvanouwerkerk+watch_chromium.org, dglazkov+blink, kinuko+serviceworker, horo+watch_chromium.org, peter+watch_chromium.org
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Remove left-overs of PushSubscription.curve25519dh These had to remain in place while a Chromium test got updated. This can be safely removed entirely now. This CL is part of a three-sided patch: [1] https://codereview.chromium.org/1309723004/ [2] https://codereview.chromium.org/1314893002/ [3] This CL. BUG=486040 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201403

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -14 lines) Patch
M LayoutTests/http/tests/push_messaging/subscribe-encryption-public-key.html View 1 chunk +0 lines, -3 lines 0 comments Download
M LayoutTests/http/tests/serviceworker/webexposed/global-interface-listing-service-worker-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/webexposed/global-interface-listing-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M Source/modules/push_messaging/PushSubscription.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/modules/push_messaging/PushSubscription.cpp View 1 chunk +0 lines, -5 lines 0 comments Download
M Source/modules/push_messaging/PushSubscription.idl View 1 chunk +0 lines, -3 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 6 (2 generated)
Peter Beverloo
PTAL
5 years, 4 months ago (2015-08-25 13:20:11 UTC) #2
Michael van Ouwerkerk
lgtm
5 years, 4 months ago (2015-08-25 16:18:17 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1316693002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1316693002/1
5 years, 3 months ago (2015-08-28 13:15:44 UTC) #5
commit-bot: I haz the power
5 years, 3 months ago (2015-08-28 14:41:15 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=201403

Powered by Google App Engine
This is Rietveld 408576698