Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(86)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1309723004: Change PushSubscription.curve25519dh to PushSubscription.getKey() (Closed)

Created:
5 years, 4 months ago by Peter Beverloo
Modified:
5 years, 3 months ago
CC:
blink-reviews, michaeln, jsbell+serviceworker_chromium.org, kenjibaheux+watch_chromium.org, tzik, johnme+watch_chromium.org, serviceworker-reviews, nhiroki, falken, mvanouwerkerk+watch_chromium.org, dglazkov+blink, kinuko+serviceworker, horo+watch_chromium.org, peter+watch_chromium.org
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Change PushSubscription.curve25519dh to PushSubscription.getKey() Using a method is deemed more readable than having a weirdly named parameter. The "curve25519dh" value still needs to be passed in as the first and only argument of the getKey() method. This CL is part of a three-sided patch: [1] This CL. [2] https://codereview.chromium.org/1314893002/ [3] https://codereview.chromium.org/1316693002/ BUG=486040 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201141

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -5 lines) Patch
M LayoutTests/http/tests/push_messaging/subscribe-encryption-public-key.html View 1 chunk +13 lines, -5 lines 0 comments Download
M LayoutTests/http/tests/serviceworker/webexposed/global-interface-listing-service-worker-expected.txt View 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/webexposed/global-interface-listing-expected.txt View 1 chunk +1 line, -0 lines 0 comments Download
M Source/modules/push_messaging/PushSubscription.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/modules/push_messaging/PushSubscription.cpp View 1 chunk +8 lines, -0 lines 0 comments Download
M Source/modules/push_messaging/PushSubscription.idl View 1 chunk +7 lines, -0 lines 0 comments Download

Dependent Patchsets:

Issue 1316693002 Patch 1

Messages

Total messages: 11 (4 generated)
Peter Beverloo
PTAL
5 years, 4 months ago (2015-08-25 13:19:47 UTC) #2
Michael van Ouwerkerk
lgtm
5 years, 4 months ago (2015-08-25 16:18:12 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1309723004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1309723004/1
5 years, 3 months ago (2015-08-25 16:26:26 UTC) #5
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. Only full committers are accepted. Even if an ...
5 years, 3 months ago (2015-08-25 16:26:28 UTC) #7
Michael van Ouwerkerk
tsk, needs mvanouwerkerk@chromium.org lgtm
5 years, 3 months ago (2015-08-25 16:31:09 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1309723004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1309723004/1
5 years, 3 months ago (2015-08-25 16:33:11 UTC) #10
commit-bot: I haz the power
5 years, 3 months ago (2015-08-25 17:48:25 UTC) #11
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=201141

Powered by Google App Engine
This is Rietveld 408576698