Chromium Code Reviews Chromium Code Reviews
Issue
1316673009:
Revert of Add a FOUC painting test. (Closed)
DescriptionRevert of Add a FOUC painting test. (patchset #6 id:100001 of https://codereview.chromium.org/1329553004/ )
Reason for revert:
This patch is failing on debug bots, all platforms. For example:
* https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20%28dbg%29/builds/3244
* https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac10.7%20%28dbg%29/builds/24575
Original issue's description:
> Add a FOUC painting test.
>
> This expands the Sim(ulation) testing framework to support a very rudimentary
> compositor that can run a simple BeginMainFrame which runs the WebView's
> beginFrame() and layout() steps followed by a simplified paint step which paints
> the main layer of every composited layer mapping. This is a very rough
> approximation of what the real compositor would do, but is enough to test the
> code for avoiding FOUC in DeprecatedPaintLayerPainter's shouldSuppressPaintingLayer
> and BlockPainter::paintContents. It's also enough to test the paint invalidation
> logic in Document::styleResolverChanged for when we painted by skipping painting
> the actual content because of the previously mentioned FOUC avoidance logic.
>
> I also went and added a bunch of comments to the Sim* classes to explain what
> they do and how to use the testing framework. A future patch may add a README
> so we can use this framework to write future pipeline tests.
>
> BUG=521692
>
> Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201944
TBR=dglazkov@chromium.org,pdr@chromium.org,esprehn@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=521692
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201960
Patch Set 1 #Messages
Total messages: 3 (0 generated)
|
