Issue 1316673008: [builtins] Removing %_CallFunction in GetThirdIndex.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1316673008: [builtins] Removing %_CallFunction in GetThirdIndex. (Closed)

Created:
5 years, 3 months ago by Camillo Bruni

Modified:
5 years, 3 months ago

Reviewers:
Benedikt Meurer

CC:
v8-dev

Base URL:
https://chromium.googlesource.com/v8/v8.git@2015-09-09_CallFunction_cleanup_1325573004

Target Ref:
refs/pending/heads/master

Project:
v8

Visibility:
Public.

More Reviews

Description

[builtins] Removing %_CallFunction in GetThirdIndex. By using an InternArray for the pivot calculation we can get rid of yet another %_CallFunction. Committed: https://crrev.com/a93ffde366ee1d8bc42827f7e10f9ff20c2df065 Cr-Commit-Position: refs/heads/master@{#30636}

Patch Set 1 #

Created: 5 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -4 lines)			Patch
	M	src/array.js	View		1 chunk	+8 lines, -4 lines	0 comments	Download

Depends on Patchset:

Issue 1325573004 Patch 20001

Messages

Total messages: 7 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1316673008/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1316673008/1

5 years, 3 months ago (2015-09-08 13:43:45 UTC) #5

commit-bot: I haz the power

5 years, 3 months ago (2015-09-08 14:22:35 UTC) #7

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/a93ffde366ee1d8bc42827f7e10f9ff20c2df065
Cr-Commit-Position: refs/heads/master@{#30636}

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages