Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(335)

Issue 1316673007: Fix handling of large xml documents (Closed)

Created:
5 years, 3 months ago by scottmg
Modified:
5 years, 2 months ago
CC:
blink-reviews
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Fix handling of large xml documents libxml 2.9.0 (we updated from 2.7.x to 2.9.2 for M45) added a default-on abort on > 10,000,000 byte documents which is a bit arbitrary and is causing problems for users. The _HUGE option makes it not do this. My assumption is that this is reasonable behaviour security-wise as: 1) we were doing it this way until recently; and 2) it shouldn't be any worse in the renderer than just doing `for (;;) x+='y';` (There's a big trivial xml file in LayoutTests/http/tests/xmlhttprequest/resources/big.xml that goes with the test, but git cl upload won't upload it. I guess I'll dcommit just that file first?) R=dominicc@chromium.org BUG=528078, 463958 TEST=LayoutTests/http/tests/xmlhttprequest/xmlhttprequest-big-document.html Committed: https://crrev.com/c73ad41c39b80ca368902a7f58fc9763b8661728 git-svn-id: svn://svn.chromium.org/blink/trunk@201992 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Patch Set 1 #

Patch Set 2 : fix location #

Patch Set 3 : . #

Patch Set 4 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -4 lines) Patch
A + LayoutTests/http/tests/xmlhttprequest/resources/big.xml View 1 2 3 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/http/tests/xmlhttprequest/xmlhttprequest-big-document.html View 1 2 3 1 chunk +8 lines, -4 lines 0 comments Download
A LayoutTests/http/tests/xmlhttprequest/xmlhttprequest-big-document-expected.txt View 1 2 3 1 chunk +6 lines, -0 lines 0 comments Download
M Source/core/xml/parser/XMLDocumentParser.cpp View 1 2 3 2 chunks +3 lines, -1 line 0 comments Download

Messages

Total messages: 16 (6 generated)
scottmg
5 years, 3 months ago (2015-09-04 20:07:58 UTC) #1
dominicc (has gone to gerrit)
lgtm
5 years, 3 months ago (2015-09-07 04:35:58 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1316673007/10002 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1316673007/10002
5 years, 3 months ago (2015-09-07 04:36:03 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/103853)
5 years, 3 months ago (2015-09-07 05:38:07 UTC) #6
scottmg
I landed the resource xml (here https://codereview.chromium.org/1328093005 but it's useless), so going to cq this ...
5 years, 3 months ago (2015-09-08 17:03:27 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1316673007/10002 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1316673007/10002
5 years, 3 months ago (2015-09-08 17:03:33 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/110160)
5 years, 3 months ago (2015-09-08 17:48:39 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1316673007/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1316673007/20001
5 years, 3 months ago (2015-09-09 17:44:39 UTC) #14
commit-bot: I haz the power
Committed patchset #4 (id:20001) as https://src.chromium.org/viewvc/blink?view=rev&revision=201992
5 years, 3 months ago (2015-09-09 18:55:47 UTC) #15
commit-bot: I haz the power
5 years, 2 months ago (2015-09-23 12:01:41 UTC) #16
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/c73ad41c39b80ca368902a7f58fc9763b8661728

Powered by Google App Engine
This is Rietveld 408576698