LayoutTests/http/tests/xmlhttprequest/xmlhttprequest-big-document.html - Issue 1316673007: Fix handling of large xml documents

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: LayoutTests/http/tests/xmlhttprequest/xmlhttprequest-big-document.html

Issue 1316673007: Fix handling of large xml documents (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: rebase Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « LayoutTests/http/tests/xmlhttprequest/resources/big.xml ('k') | LayoutTests/http/tests/xmlhttprequest/xmlhttprequest-big-document-expected.txt » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: LayoutTests/http/tests/xmlhttprequest/xmlhttprequest-big-document.html

diff --git a/LayoutTests/http/tests/xmlhttprequest/xmlhttprequest-post-crash.html b/LayoutTests/http/tests/xmlhttprequest/xmlhttprequest-big-document.html

similarity index 50%

copy from LayoutTests/http/tests/xmlhttprequest/xmlhttprequest-post-crash.html

copy to LayoutTests/http/tests/xmlhttprequest/xmlhttprequest-big-document.html

index dea83264595bc46f249a77e1fd097f5d14a4bdf8..c42fed6188b98123939dc52a891f539370af42cb 100644

--- a/LayoutTests/http/tests/xmlhttprequest/xmlhttprequest-post-crash.html

+++ b/LayoutTests/http/tests/xmlhttprequest/xmlhttprequest-big-document.html

@@ -10,20 +10,24 @@ if (window.testRunner) {

var xhr = new XMLHttpRequest();

xhr.onreadystatechange = function() {

- if (xhr.readyState == 4) {

+ if (xhr.readyState == 4 && xhr.status == 200) {

+ var doc = xhr.responseXML;

+ var children = doc.getElementsByTagName("child");

+ console.log(children);

document.getElementById("page").textContent = "PASS";

if (window.testRunner)

testRunner.notifyDone();

}

-xhr.open("POST", "resources/1251.html", true);

+xhr.open("GET", "resources/big.xml", true);

xhr.send(null);

</script>

</head>

<body>

-<p> Test case for <a href="http://bugs.webkit.org/show_bug.cgi?id=16906">bug 16906</a>: [CURL] Crash below ResourceHandleManager::setupPOST when job->request().httpBody() is NULL </p>

-<p> This page should not crash and you should see PASS</p>

+<p> Test case for <a href="https://code.google.com/p/chromium/issues/detail?id=528078">bug 528078</a>: XML files fail to parse if over 10 million bytes in size</p>

+<p> You should see PASS.</p>

</body>

</html>