Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(96)

Issue 1316563002: Remove invalid compiler arg: (Closed)

Created:
5 years, 4 months ago by Dan Beam
Modified:
5 years, 3 months ago
CC:
chromium-reviews, vitalyp+closure_chromium.org, jlklein+watch-closure_chromium.org, dbeam+watch-closure_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove invalid compiler arg: - accept_const_keyword And invalid jscomp_error value: - checkStructDictInheritance Both are obsolete in new versions of closure compiler (which I'm trying to update to). TBR=tbreisacher@chromium.org,stuartmorgan@chromium.org BUG=none TEST=closure compilation works Committed: https://crrev.com/bc7915c52045d2507440a8eccbe050368bc5e641 Cr-Commit-Position: refs/heads/master@{#345260}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -5 lines) Patch
M ios/web/js_compile_checked.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/closure_compiler/closure_args.gni View 2 chunks +0 lines, -2 lines 0 comments Download
M third_party/closure_compiler/closure_args.gypi View 2 chunks +0 lines, -2 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 7 (2 generated)
Dan Beam
5 years, 4 months ago (2015-08-25 03:20:17 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1316563002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1316563002/1
5 years, 4 months ago (2015-08-25 03:20:39 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 4 months ago (2015-08-25 05:03:00 UTC) #5
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/bc7915c52045d2507440a8eccbe050368bc5e641 Cr-Commit-Position: refs/heads/master@{#345260}
5 years, 4 months ago (2015-08-25 05:03:48 UTC) #6
stuartmorgan
5 years, 3 months ago (2015-09-02 22:18:39 UTC) #7
Message was sent while issue was closed.
ios/ LGTM

Powered by Google App Engine
This is Rietveld 408576698