Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(555)

Issue 1309843003: Remove @suppress {checkStructDictInheritance} from ui/file_manager (Closed)

Created:
5 years, 4 months ago by Dan Beam
Modified:
5 years, 4 months ago
Reviewers:
fukino
CC:
chromium-reviews, rginda+watch_chromium.org, mtomasz+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@remove-args
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove @suppress {checkStructDictInheritance} from ui/file_manager It's no longer a compiler error. TBR=fukino@chromium.org BUG=none TEST=closure compiler bot Committed: https://crrev.com/bdbff3d1f135784701a56ec306fa3c9639fcd26c Cr-Commit-Position: refs/heads/master@{#345274}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -18 lines) Patch
M ui/file_manager/file_manager/background/js/drive_sync_handler.js View 1 chunk +0 lines, -1 line 0 comments Download
M ui/file_manager/file_manager/background/js/file_operation_manager.js View 1 chunk +0 lines, -1 line 0 comments Download
M ui/file_manager/file_manager/common/js/externs.js View 1 chunk +0 lines, -1 line 0 comments Download
M ui/file_manager/file_manager/foreground/js/file_selection.js View 1 chunk +0 lines, -1 line 0 comments Download
M ui/file_manager/file_manager/foreground/js/list_thumbnail_loader.js View 2 chunks +0 lines, -2 lines 0 comments Download
M ui/file_manager/file_manager/foreground/js/metadata/content_metadata_provider.js View 1 chunk +0 lines, -1 line 0 comments Download
M ui/file_manager/file_manager/foreground/js/metadata/metadata_cache_set.js View 1 chunk +0 lines, -1 line 0 comments Download
M ui/file_manager/file_manager/foreground/js/navigation_list_model.js View 3 chunks +0 lines, -3 lines 0 comments Download
M ui/file_manager/file_manager/foreground/js/ui/file_grid.js View 1 chunk +0 lines, -1 line 0 comments Download
M ui/file_manager/file_manager/foreground/js/ui/file_list_selection_model.js View 2 chunks +0 lines, -2 lines 0 comments Download
M ui/file_manager/file_manager/foreground/js/ui/file_table_list.js View 2 chunks +0 lines, -2 lines 0 comments Download
M ui/file_manager/gallery/js/ribbon.js View 1 chunk +0 lines, -1 line 0 comments Download
M ui/file_manager/gallery/js/slide_mode.js View 1 chunk +0 lines, -1 line 0 comments Download

Depends on Patchset:

Messages

Total messages: 6 (1 generated)
Dan Beam
5 years, 4 months ago (2015-08-25 03:59:33 UTC) #1
fukino
lgtm. Thank you!
5 years, 4 months ago (2015-08-25 04:05:13 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1309843003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1309843003/1
5 years, 4 months ago (2015-08-25 06:33:38 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 4 months ago (2015-08-25 06:39:42 UTC) #5
commit-bot: I haz the power
5 years, 4 months ago (2015-08-25 06:40:22 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/bdbff3d1f135784701a56ec306fa3c9639fcd26c
Cr-Commit-Position: refs/heads/master@{#345274}

Powered by Google App Engine
This is Rietveld 408576698