Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(415)

Issue 1316543003: Refactor ProximityAuthUIDelegate functions to ProximityAuthClient. (Closed)

Created:
5 years, 4 months ago by Tim Song
Modified:
5 years, 3 months ago
Reviewers:
sacomoto, msarda
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Mirror ProximityAuthUIDelegate functions to ProximityAuthClient. Both classes are embedder interfaces for the proximity_auth/ component to delegate to Chrome. This CL is the first step to move the delegate functions solely to ProximityAuthClient. The next CL will remove the ProximityAuthUIDelegate class. BUG=512230 Committed: https://crrev.com/13d636780595c920e4c53c0b8335ca9c85409079 Cr-Commit-Position: refs/heads/master@{#346005}

Patch Set 1 : #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+203 lines, -39 lines) Patch
M chrome/browser/signin/chrome_proximity_auth_client.h View 2 chunks +12 lines, -0 lines 0 comments Download
M chrome/browser/signin/chrome_proximity_auth_client.cc View 2 chunks +76 lines, -0 lines 3 comments Download
M components/proximity_auth.gypi View 1 chunk +3 lines, -0 lines 0 comments Download
M components/proximity_auth/BUILD.gn View 1 chunk +3 lines, -0 lines 0 comments Download
M components/proximity_auth/ble/proximity_auth_ble_system_unittest.cc View 2 chunks +1 line, -20 lines 0 comments Download
A components/proximity_auth/mock_proximity_auth_client.h View 1 chunk +50 lines, -0 lines 0 comments Download
A components/proximity_auth/mock_proximity_auth_client.cc View 1 chunk +23 lines, -0 lines 0 comments Download
M components/proximity_auth/proximity_auth_client.h View 2 chunks +34 lines, -3 lines 0 comments Download
M components/proximity_auth/unlock_manager_unittest.cc View 2 chunks +1 line, -16 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 12 (4 generated)
Tim Song
5 years, 4 months ago (2015-08-25 03:02:50 UTC) #3
Tim Song
5 years, 3 months ago (2015-08-26 02:43:19 UTC) #5
sacomoto
In the CL description, you meant ProximityAuthUIDelegate, right? If that's the case, please update it ...
5 years, 3 months ago (2015-08-27 11:29:31 UTC) #6
Tim Song
https://codereview.chromium.org/1316543003/diff/20001/chrome/browser/signin/chrome_proximity_auth_client.cc File chrome/browser/signin/chrome_proximity_auth_client.cc (right): https://codereview.chromium.org/1316543003/diff/20001/chrome/browser/signin/chrome_proximity_auth_client.cc#newcode95 chrome/browser/signin/chrome_proximity_auth_client.cc:95: device_classifier.set_device_type(cryptauth::CHROME); On 2015/08/27 11:29:31, sacomoto wrote: > This is ...
5 years, 3 months ago (2015-08-27 18:23:52 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1316543003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1316543003/20001
5 years, 3 months ago (2015-08-27 20:24:40 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:20001)
5 years, 3 months ago (2015-08-27 22:19:31 UTC) #10
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/13d636780595c920e4c53c0b8335ca9c85409079 Cr-Commit-Position: refs/heads/master@{#346005}
5 years, 3 months ago (2015-08-27 22:19:55 UTC) #11
sacomoto
5 years, 3 months ago (2015-08-28 14:40:23 UTC) #12
Message was sent while issue was closed.
https://codereview.chromium.org/1316543003/diff/20001/chrome/browser/signin/c...
File chrome/browser/signin/chrome_proximity_auth_client.cc (right):

https://codereview.chromium.org/1316543003/diff/20001/chrome/browser/signin/c...
chrome/browser/signin/chrome_proximity_auth_client.cc:95:
device_classifier.set_device_type(cryptauth::CHROME);
On 2015/08/27 18:23:52, Tim Song wrote:
> On 2015/08/27 11:29:31, sacomoto wrote:
> > This is sent to CryptAuth, right? Why does it need all this information?
> 
> The people maintaining CryptAuth want to distinguish API calls made by
different
> platforms (e.g. Android vs. Chrome).

I see. Thanks.

Powered by Google App Engine
This is Rietveld 408576698