Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(67)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1302313004: Replace ProximityAuthUIDelegate with ProximityAuthClient. (Closed)

Created:
5 years, 4 months ago by Tim Song
Modified:
5 years, 3 months ago
Reviewers:
xiyuan, sacomoto, msarda
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@proximity_auth_client
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Replace ProximityAuthUIDelegate with ProximityAuthClient. BUG=512230 Committed: https://crrev.com/4d3cff16a3a2282f6c7b47772b8f57c572017179 Cr-Commit-Position: refs/heads/master@{#346217}

Patch Set 1 #

Total comments: 2

Patch Set 2 : fixes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+89 lines, -307 lines) Patch
M chrome/browser/signin/easy_unlock_service.h View 3 chunks +1 line, -13 lines 0 comments Download
M chrome/browser/signin/easy_unlock_service.cc View 3 chunks +2 lines, -58 lines 0 comments Download
M chrome/browser/signin/easy_unlock_service_regular.cc View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/chrome_web_ui_controller_factory.cc View 1 1 chunk +2 lines, -1 line 0 comments Download
M components/proximity_auth.gypi View 1 chunk +0 lines, -3 lines 0 comments Download
M components/proximity_auth/webui/BUILD.gn View 1 chunk +0 lines, -3 lines 0 comments Download
D components/proximity_auth/webui/cryptauth_enroller_factory_impl.h View 1 chunk +0 lines, -35 lines 0 comments Download
D components/proximity_auth/webui/cryptauth_enroller_factory_impl.cc View 1 chunk +0 lines, -28 lines 0 comments Download
M components/proximity_auth/webui/proximity_auth_ui.h View 1 chunk +2 lines, -2 lines 0 comments Download
M components/proximity_auth/webui/proximity_auth_ui.cc View 1 chunk +1 line, -1 line 0 comments Download
D components/proximity_auth/webui/proximity_auth_ui_delegate.h View 1 chunk +0 lines, -50 lines 0 comments Download
M components/proximity_auth/webui/proximity_auth_webui_handler.h View 1 4 chunks +8 lines, -10 lines 0 comments Download
M components/proximity_auth/webui/proximity_auth_webui_handler.cc View 14 chunks +71 lines, -102 lines 0 comments Download

Depends on Patchset:

Issue 1316543003 Patch 20001

Dependent Patchsets:

Issue 1308393007 Patch 180001

Messages

Total messages: 18 (7 generated)
Tim Song
5 years, 4 months ago (2015-08-25 19:58:20 UTC) #2
Tim Song
5 years, 4 months ago (2015-08-26 02:43:26 UTC) #4
sacomoto
s/ProximityAuthWebUIDelegate/ProximityAuthUIDelegate/ in the description. LGTM with nits. https://codereview.chromium.org/1302313004/diff/1/components/proximity_auth/webui/proximity_auth_webui_handler.h File components/proximity_auth/webui/proximity_auth_webui_handler.h (right): https://codereview.chromium.org/1302313004/diff/1/components/proximity_auth/webui/proximity_auth_webui_handler.h#newcode170 components/proximity_auth/webui/proximity_auth_webui_handler.h:170: scoped_ptr<PrefService> pref_service; ...
5 years, 3 months ago (2015-08-27 12:09:17 UTC) #5
Tim Song
https://codereview.chromium.org/1302313004/diff/1/components/proximity_auth/webui/proximity_auth_webui_handler.h File components/proximity_auth/webui/proximity_auth_webui_handler.h (right): https://codereview.chromium.org/1302313004/diff/1/components/proximity_auth/webui/proximity_auth_webui_handler.h#newcode170 components/proximity_auth/webui/proximity_auth_webui_handler.h:170: scoped_ptr<PrefService> pref_service; On 2015/08/27 12:09:17, sacomoto wrote: > Please ...
5 years, 3 months ago (2015-08-27 18:28:04 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1302313004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1302313004/20001
5 years, 3 months ago (2015-08-28 01:34:07 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/93933)
5 years, 3 months ago (2015-08-28 01:43:40 UTC) #11
Tim Song
+xiyuan for chrome/browser/ui/webui/chrome_web_ui_controller_factory.cc
5 years, 3 months ago (2015-08-28 02:21:49 UTC) #13
xiyuan
chrome_web_ui_controller_factory.cc LGTM
5 years, 3 months ago (2015-08-28 03:22:22 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1302313004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1302313004/20001
5 years, 3 months ago (2015-08-28 19:57:44 UTC) #16
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 3 months ago (2015-08-28 20:02:59 UTC) #17
commit-bot: I haz the power
5 years, 3 months ago (2015-08-28 20:04:12 UTC) #18
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/4d3cff16a3a2282f6c7b47772b8f57c572017179
Cr-Commit-Position: refs/heads/master@{#346217}

Powered by Google App Engine
This is Rietveld 408576698