Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(198)

Issue 1316493006: [sql] Record SQLite memory usage after a week. (Closed)

Created:
5 years, 4 months ago by Scott Hess - ex-Googler
Modified:
5 years, 4 months ago
CC:
chromium-reviews, asvitkine+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[sql] Record SQLite memory usage after a week. Previously landed 10-minute, 1-hour, and 1-day histograms. Based on those I expect 1-week to get around 20% worse. BUG=489784 Committed: https://crrev.com/2d48e948d46a3c288e7147867a5978aa647b2344 Cr-Commit-Position: refs/heads/master@{#345366}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -0 lines) Patch
M sql/connection.cc View 2 chunks +8 lines, -0 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
Scott Hess - ex-Googler
Per email thread, might this be worth getting in before branch to get longer-term numbers ...
5 years, 4 months ago (2015-08-24 22:51:08 UTC) #2
rmcilroy
lgtm
5 years, 4 months ago (2015-08-24 23:45:05 UTC) #3
Scott Hess - ex-Googler
Alexei, extending https://codereview.chromium.org/1283033004 . Simply didn't occur to me at the time that longer than ...
5 years, 4 months ago (2015-08-24 23:48:40 UTC) #5
Alexei Svitkine (slow)
lgtm
5 years, 4 months ago (2015-08-25 15:12:58 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1316493006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1316493006/1
5 years, 4 months ago (2015-08-25 16:21:25 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 4 months ago (2015-08-25 17:40:00 UTC) #9
commit-bot: I haz the power
5 years, 4 months ago (2015-08-25 17:40:55 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2d48e948d46a3c288e7147867a5978aa647b2344
Cr-Commit-Position: refs/heads/master@{#345366}

Powered by Google App Engine
This is Rietveld 408576698