Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(148)

Issue 1283033004: [sql] Record memory usage at various periods after startup. (Closed)

Created:
5 years, 4 months ago by Scott Hess - ex-Googler
Modified:
5 years, 4 months ago
CC:
chromium-reviews, asvitkine+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[sql] Record memory usage at various periods after startup. This will be used to track improvements occuring from enabling memory-mapped I/O. BUG=489784 Committed: https://crrev.com/c9e80ae207673d875e62d8c11d4d1e8ad4804366 Cr-Commit-Position: refs/heads/master@{#343100}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Naming suggestion. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+61 lines, -1 line) Patch
M sql/connection.cc View 1 3 chunks +37 lines, -1 line 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 1 chunk +24 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
Scott Hess - ex-Googler
I've been polishing a mmap CL, and thought maybe this should be landed a few ...
5 years, 4 months ago (2015-08-11 22:12:10 UTC) #2
rmcilroy
On 2015/08/11 22:12:10, Scott Hess wrote: > I've been polishing a mmap CL, and thought ...
5 years, 4 months ago (2015-08-12 10:50:50 UTC) #3
Scott Hess - ex-Googler
Alexei, you put yourself on the watchlist, so maybe I'll upgrade you to reviewer for ...
5 years, 4 months ago (2015-08-12 20:04:20 UTC) #5
Alexei Svitkine (slow)
lgtm % naming suggestion https://codereview.chromium.org/1283033004/diff/1/tools/metrics/histograms/histograms.xml File tools/metrics/histograms/histograms.xml (right): https://codereview.chromium.org/1283033004/diff/1/tools/metrics/histograms/histograms.xml#newcode42835 tools/metrics/histograms/histograms.xml:42835: +<histogram name="Sqlite.MemoryKBOneDay" units="KB"> Nit: Suggest ...
5 years, 4 months ago (2015-08-12 20:17:21 UTC) #6
Scott Hess - ex-Googler
Thanks all! https://codereview.chromium.org/1283033004/diff/1/tools/metrics/histograms/histograms.xml File tools/metrics/histograms/histograms.xml (right): https://codereview.chromium.org/1283033004/diff/1/tools/metrics/histograms/histograms.xml#newcode42835 tools/metrics/histograms/histograms.xml:42835: +<histogram name="Sqlite.MemoryKBOneDay" units="KB"> On 2015/08/12 20:17:21, Alexei ...
5 years, 4 months ago (2015-08-12 20:23:43 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1283033004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1283033004/20001
5 years, 4 months ago (2015-08-12 20:34:57 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 4 months ago (2015-08-12 21:39:20 UTC) #11
commit-bot: I haz the power
5 years, 4 months ago (2015-08-12 21:40:33 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/c9e80ae207673d875e62d8c11d4d1e8ad4804366
Cr-Commit-Position: refs/heads/master@{#343100}

Powered by Google App Engine
This is Rietveld 408576698