Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(123)

Issue 1316333002: [strong] weak classes can't inherit from strong ones (Closed)

Created:
5 years, 3 months ago by conradw
Modified:
5 years, 3 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[strong] weak classes can't inherit from strong ones Prerequisite for sealing strong class instances. Depends on https://codereview.chromium.org/1314203002/ BUG=v8:3956 LOG=N Committed: https://crrev.com/db440dfe8d776ca3f0a5a21f6cfce070814649c5 Cr-Commit-Position: refs/heads/master@{#30541}

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : remove unused test class #

Patch Set 4 : fix smi case #

Patch Set 5 : minor comment reorder #

Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -52 lines) Patch
M src/compiler/ast-graph-builder.cc View 1 1 chunk +1 line, -4 lines 0 comments Download
M src/full-codegen/full-codegen.cc View 1 1 chunk +1 line, -3 lines 0 comments Download
M src/messages.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M src/runtime/runtime.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M src/runtime/runtime-classes.cc View 1 2 3 4 2 chunks +12 lines, -22 lines 0 comments Download
M test/mjsunit/strong/class-object-frozen.js View 1 chunk +0 lines, -17 lines 0 comments Download
A test/mjsunit/strong/class-weak-extend.js View 1 chunk +28 lines, -0 lines 0 comments Download
M test/mjsunit/strong/literals.js View 1 2 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
conradw
PTAL
5 years, 3 months ago (2015-09-02 08:44:56 UTC) #2
Benedikt Meurer
LGTM!
5 years, 3 months ago (2015-09-02 11:03:56 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1316333002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1316333002/80001
5 years, 3 months ago (2015-09-02 11:29:06 UTC) #6
commit-bot: I haz the power
Committed patchset #5 (id:80001)
5 years, 3 months ago (2015-09-02 11:36:11 UTC) #7
commit-bot: I haz the power
5 years, 3 months ago (2015-09-02 11:36:28 UTC) #8
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/db440dfe8d776ca3f0a5a21f6cfce070814649c5
Cr-Commit-Position: refs/heads/master@{#30541}

Powered by Google App Engine
This is Rietveld 408576698