src/full-codegen/full-codegen.cc - Issue 1316333002: [strong] weak classes can't inherit from strong ones

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/full-codegen/full-codegen.cc

Issue 1316333002: [strong] weak classes can't inherit from strong ones (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: minor comment reorder Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/full-codegen/full-codegen.cc

diff --git a/src/full-codegen/full-codegen.cc b/src/full-codegen/full-codegen.cc

index fa2f921d016786a56b276f854f99360db42db684..5ef9d0a0b935eb2f163cb43f4bd1785010135320 100644

--- a/src/full-codegen/full-codegen.cc

+++ b/src/full-codegen/full-codegen.cc

@@ -1297,9 +1297,7 @@ void FullCodeGenerator::VisitClassLiteral(ClassLiteral* lit) {

__ Push(Smi::FromInt(lit->start_position()));

__ Push(Smi::FromInt(lit->end_position()));

- __ CallRuntime(is_strong(language_mode()) ? Runtime::kDefineClassStrong

- : Runtime::kDefineClass,

- 5);

+ __ CallRuntime(Runtime::kDefineClass, 5);

PrepareForBailoutForId(lit->CreateLiteralId(), TOS_REG);

int store_slot_index = 0;

« no previous file with comments | « src/compiler/ast-graph-builder.cc ('k') | src/messages.h » ('j') | no next file with comments »