Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(55)

Issue 1316293002: [ServiceWorker] Use appopriate type parameters for WebCallbacks (3/3) (Closed)

Created:
5 years, 3 months ago by yhirano
Modified:
5 years, 3 months ago
Reviewers:
nhiroki
CC:
blink-reviews, dglazkov+blink
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

[ServiceWorker] Use appopriate type parameters for WebCallbacks (3/3) - WebServiceWorkerRegistration* (ownership transferred) => WebPassOwnPtr<WebServiceWorkerRegistration> - WebVector<WebServiceWorkerRegistration*> (ownership transferred) => WebPassOwnPtr<WebVector<WebServiceWorkerRegistration*>> - WebServiceWorkerError* (ownership transferred) => const WebServiceWorkerError& 1/3: https://codereview.chromium.org/1312343004/ 2/3: https://codereview.chromium.org/1318953002/ 3/3: https://codereview.chromium.org/1316293002/ BUG=493531, 525340 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201351

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -28 lines) Patch
M public/platform/modules/serviceworker/WebServiceWorkerProvider.h View 1 chunk +6 lines, -28 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 7 (2 generated)
yhirano
5 years, 3 months ago (2015-08-27 13:39:20 UTC) #2
nhiroki
lgtm
5 years, 3 months ago (2015-08-27 14:06:47 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1316293002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1316293002/1
5 years, 3 months ago (2015-08-28 00:31:56 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://src.chromium.org/viewvc/blink?view=rev&revision=201351
5 years, 3 months ago (2015-08-28 01:16:40 UTC) #6
nhiroki
5 years, 3 months ago (2015-09-03 02:22:17 UTC) #7
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1322283002/ by nhiroki@chromium.org.

The reason for reverting is: According to http://crbug.com/523904 (see c#11),
these callbacks will not always receive object ownership, so let me revert this
series of CLs. Sorry for wasting your time....

Powered by Google App Engine
This is Rietveld 408576698