Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(167)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1312343004: [ServiceWorker] Use appopriate type parameters for WebCallbacks (1/3) (Closed)

Created:
5 years, 3 months ago by yhirano
Modified:
5 years, 3 months ago
Reviewers:
nhiroki
CC:
blink-reviews, michaeln, jsbell+serviceworker_chromium.org, tzik, serviceworker-reviews, nhiroki, falken, dglazkov+blink, kinuko+serviceworker, horo+watch_chromium.org
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

[ServiceWorker] Use appopriate type parameters for WebCallbacks (1/3) - WebServiceWorkerRegistration* (ownership transferred) => WebPassOwnPtr<WebServiceWorkerRegistration> - WebVector<WebServiceWorkerRegistration*> (ownership transferred) => WebPassOwnPtr<WebVector<WebServiceWorkerRegistration*>> - WebServiceWorkerError* (ownership transferred) => const WebServiceWorkerError& This CL also fixes a memory leak in GetRegistrationsCallback::onSuccess. 1/3: https://codereview.chromium.org/1312343004/ 2/3: https://codereview.chromium.org/1318953002/ 3/3: https://codereview.chromium.org/1316293002/ BUG=493531, 525340 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201321

Patch Set 1 : #

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+51 lines, -36 lines) Patch
M Source/modules/serviceworkers/ServiceWorkerContainer.cpp View 1 2 5 chunks +19 lines, -27 lines 0 comments Download
M Source/modules/serviceworkers/ServiceWorkerRegistration.h View 1 chunk +3 lines, -3 lines 0 comments Download
M public/platform/modules/serviceworker/WebServiceWorkerProvider.h View 1 2 chunks +29 lines, -6 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
yhirano
5 years, 3 months ago (2015-08-27 13:39:05 UTC) #3
nhiroki
LGTM! Can you add 525340 to BUG=?
5 years, 3 months ago (2015-08-27 14:02:36 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1312343004/50001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1312343004/50001
5 years, 3 months ago (2015-08-27 15:22:21 UTC) #6
commit-bot: I haz the power
5 years, 3 months ago (2015-08-27 16:30:34 UTC) #7
Message was sent while issue was closed. 
Committed patchset #3 (id:50001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=201321

Powered by Google App Engine
This is Rietveld 408576698