Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(458)

Issue 1316213004: Merge 201348 "Fix   fallback glyph lookup" (Closed)

Created:
5 years, 3 months ago by kochi
Modified:
5 years, 3 months ago
Reviewers:
kochi
CC:
blink-reviews, krit, drott+blinkwatch_chromium.org, Rik, dshwang, jbroman, Justin Novosad, danakj, pdr+graphicswatchlist_chromium.org, f(malita), Stephen Chennney, rwlbuis
Visibility:
Public.

Description

Merge 201348 "Fix   fallback glyph lookup" > Fix   fallback glyph lookup > > On Japanese locale Android which has Motoya Maruberi > as the system default font (up until 5.1), the font > fallback path mistakenly picked up ".notdef" glyph > for   (U+00A0). > > This happened because in the fallback path it still > ended up in looking up non-existent glyph in the same > font file and fell back to the "missingGlyphData". > > This is because Blink looks up the glyph in > normalized codepoint (for U+00A0, normalized to U+0020) > but still it tries to look up the original codepoint. > > This bug was exposed by the following change, to make > not to normalize   to space before looking up glyph. > https://codereview.chromium.org/705163003 > > BUG=454108 > > Review URL: https://codereview.chromium.org/1317833003 TBR=kochi@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201463

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -4 lines) Patch
M Source/platform/fonts/Font.cpp View 1 chunk +5 lines, -4 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
kochi
5 years, 3 months ago (2015-08-31 04:52:04 UTC) #1
kochi
5 years, 3 months ago (2015-08-31 04:52:26 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as r201463.

Powered by Google App Engine
This is Rietveld 408576698