Issue 705163003: Use NonBreakingSpace glyph where available

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 705163003: Use NonBreakingSpace glyph where available (Closed)

Created:
6 years, 1 month ago by eae

Modified:
6 years, 1 month ago

Reviewers:
pdr.

CC:
blink-reviews, Rik, danakj, krit, f(malita), jbroman, pdr+graphicswatchlist_chromium.org, rwlbuis, Stephen Chennney

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Project:
blink

Visibility:
Public.

More Reviews

Description

Use NonBreakingSpace glyph where available Change GlyphPageTreeNode::initializePage to not override the NBSP glyph with space as some fonts may render non breaking spaces with a glyph other than space. As we already have logic falling back on space if the nbsp glyph is missing from the font no further logic is needed. R=pdr@chromium.org BUG=423539 TEST=fonts/cursive.html Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=184938

Patch Set 1 #

Patch Set 2 : #

Created: 6 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -2 lines)			Patch
	M	LayoutTests/TestExpectations	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
	M	Source/platform/fonts/GlyphPageTreeNode.cpp	View		1 chunk	+1 line, -2 lines	0 comments	Download

Messages

Total messages: 6 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/705163003/20001

6 years, 1 month ago (2014-11-06 23:00:56 UTC) #5

commit-bot: I haz the power

6 years, 1 month ago (2014-11-07 00:13:46 UTC) #6

Message was sent while issue was closed.

Committed patchset #2 (id:20001) as 184938

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages