Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(528)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1316173002: Move AbsoluteClipRects to the state machine (Closed)

Created:
5 years, 3 months ago by Julien - ping for review
Modified:
5 years, 3 months ago
CC:
blink-reviews, blink-reviews-paint_chromium.org, blink-reviews-rendering, dshwang, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, slimming-paint-reviews_chromium.org, szager+layoutwatch_chromium.org, zoltan1
Target Ref:
refs/remotes/origin/master
Project:
blink
Visibility:
Public.

Description

Move AbsoluteClipRects to the state machine The AbsoluteClipRects are now precomputed as part of the compositing update step as this is the only consumer of them (more precisely overlap testing). Added some ASSERTs to ensure we compute them at the right time and we don't hold onto stale values. BUG=515970 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201252

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -4 lines) Patch
M Source/core/frame/FrameView.cpp View 1 chunk +8 lines, -0 lines 0 comments Download
M Source/core/layout/ClipRectsCache.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/layout/compositing/CompositingInputsUpdater.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/paint/DeprecatedPaintLayer.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/paint/DeprecatedPaintLayerClipper.h View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/paint/DeprecatedPaintLayerClipper.cpp View 3 chunks +12 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Julien - ping for review
5 years, 3 months ago (2015-08-26 20:06:35 UTC) #2
leviw_travelin_and_unemployed
LGTM :)
5 years, 3 months ago (2015-08-26 20:28:05 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1316173002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1316173002/1
5 years, 3 months ago (2015-08-26 20:28:19 UTC) #5
commit-bot: I haz the power
5 years, 3 months ago (2015-08-26 22:04:24 UTC) #6
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=201252

Powered by Google App Engine
This is Rietveld 408576698