Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(675)

Side by Side Diff: Source/core/frame/FrameView.cpp

Issue 1316173002: Move AbsoluteClipRects to the state machine (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | Source/core/layout/ClipRectsCache.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1998, 1999 Torben Weis <weis@kde.org> 2 * Copyright (C) 1998, 1999 Torben Weis <weis@kde.org>
3 * 1999 Lars Knoll <knoll@kde.org> 3 * 1999 Lars Knoll <knoll@kde.org>
4 * 1999 Antti Koivisto <koivisto@kde.org> 4 * 1999 Antti Koivisto <koivisto@kde.org>
5 * 2000 Dirk Mueller <mueller@kde.org> 5 * 2000 Dirk Mueller <mueller@kde.org>
6 * Copyright (C) 2004, 2005, 2006, 2007, 2008 Apple Inc. All rights reserved. 6 * Copyright (C) 2004, 2005, 2006, 2007, 2008 Apple Inc. All rights reserved.
7 * (C) 2006 Graham Dennis (graham.dennis@gmail.com) 7 * (C) 2006 Graham Dennis (graham.dennis@gmail.com)
8 * (C) 2006 Alexey Proskuryakov (ap@nypop.com) 8 * (C) 2006 Alexey Proskuryakov (ap@nypop.com)
9 * Copyright (C) 2009 Google Inc. All rights reserved. 9 * Copyright (C) 2009 Google Inc. All rights reserved.
10 * 10 *
(...skipping 2457 matching lines...) Expand 10 before | Expand all | Expand 10 after
2468 } 2468 }
2469 2469
2470 if (RuntimeEnabledFeatures::frameTimingSupportEnabled()) 2470 if (RuntimeEnabledFeatures::frameTimingSupportEnabled())
2471 updateFrameTimingRequestsIfNeeded(); 2471 updateFrameTimingRequestsIfNeeded();
2472 2472
2473 ASSERT(!view->hasPendingSelection()); 2473 ASSERT(!view->hasPendingSelection());
2474 ASSERT(lifecycle().state() == DocumentLifecycle::PaintInvalidationCl ean 2474 ASSERT(lifecycle().state() == DocumentLifecycle::PaintInvalidationCl ean
2475 || (RuntimeEnabledFeatures::slimmingPaintV2Enabled() && lifecycl e().state() == DocumentLifecycle::CompositingForSlimmingPaintV2Clean)); 2475 || (RuntimeEnabledFeatures::slimmingPaintV2Enabled() && lifecycl e().state() == DocumentLifecycle::CompositingForSlimmingPaintV2Clean));
2476 } 2476 }
2477 } 2477 }
2478
2479 #ifndef NDEBUG
2480 // TODO(jchaffraix): We will want to clear the clip rects in release too
2481 // to reduce our long-term memory consumption. However this requires us
2482 // to migrate all of the clip rects to the state machine and evaluate
2483 // the performance impacts of this.
2484 layoutView()->layer()->clipper().clearClipRectsIncludingDescendants(Absolute ClipRects);
2485 #endif
2478 } 2486 }
2479 2487
2480 void FrameView::paintForSlimmingPaintV2() 2488 void FrameView::paintForSlimmingPaintV2()
2481 { 2489 {
2482 ASSERT(RuntimeEnabledFeatures::slimmingPaintV2Enabled()); 2490 ASSERT(RuntimeEnabledFeatures::slimmingPaintV2Enabled());
2483 ASSERT(frame() == page()->mainFrame() || (!frame().tree().parent()->isLocalF rame())); 2491 ASSERT(frame() == page()->mainFrame() || (!frame().tree().parent()->isLocalF rame()));
2484 2492
2485 LayoutView* view = layoutView(); 2493 LayoutView* view = layoutView();
2486 ASSERT(view); 2494 ASSERT(view);
2487 GraphicsLayer* rootGraphicsLayer = view->layer()->graphicsLayerBacking(); 2495 GraphicsLayer* rootGraphicsLayer = view->layer()->graphicsLayerBacking();
(...skipping 1470 matching lines...) Expand 10 before | Expand all | Expand 10 after
3958 3966
3959 if (!graphicsLayer) 3967 if (!graphicsLayer)
3960 return; 3968 return;
3961 3969
3962 DeprecatedPaintLayer::mapRectToPaintInvalidationBacking(localFrame->contentL ayoutObject(), paintInvalidationContainer, viewRect); 3970 DeprecatedPaintLayer::mapRectToPaintInvalidationBacking(localFrame->contentL ayoutObject(), paintInvalidationContainer, viewRect);
3963 3971
3964 graphicsLayerTimingRequests.add(graphicsLayer, Vector<std::pair<int64_t, Web Rect>>()).storedValue->value.append(std::make_pair(m_frame->frameID(), enclosing IntRect(viewRect))); 3972 graphicsLayerTimingRequests.add(graphicsLayer, Vector<std::pair<int64_t, Web Rect>>()).storedValue->value.append(std::make_pair(m_frame->frameID(), enclosing IntRect(viewRect)));
3965 } 3973 }
3966 3974
3967 } // namespace blink 3975 } // namespace blink
OLDNEW
« no previous file with comments | « no previous file | Source/core/layout/ClipRectsCache.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698