Source/core/paint/DeprecatedPaintLayerClipper.cpp - Issue 1316163002: Make the LayoutRect->FloatRect constructor explicit.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/paint/DeprecatedPaintLayerClipper.cpp

Issue 1316163002: Make the LayoutRect->FloatRect constructor explicit. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/paint/DeprecatedPaintLayerClipper.cpp

diff --git a/Source/core/paint/DeprecatedPaintLayerClipper.cpp b/Source/core/paint/DeprecatedPaintLayerClipper.cpp

index 1d0ea54eb3f87d220fef170844a9e2487d983156..8a727fc1271c3055c04978f64bb8c62ad008698e 100644

--- a/Source/core/paint/DeprecatedPaintLayerClipper.cpp

+++ b/Source/core/paint/DeprecatedPaintLayerClipper.cpp

@@ -95,7 +95,8 @@ LayoutRect DeprecatedPaintLayerClipper::localClipRect() const

calculateRects(context, LayoutRect(LayoutRect::infiniteIntRect()), layerBounds, backgroundRect, foregroundRect, outlineRect);

LayoutRect clipRect = backgroundRect.rect();

- if (IntRect(clipRect) == LayoutRect::infiniteIntRect())

+ // TODO(chrishtr): avoid converting to IntRect and back.

+ if (clipRect == LayoutRect(LayoutRect::infiniteIntRect()))

return clipRect;

LayoutPoint clippingRootOffset;