Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(833)

Unified Diff: Source/core/paint/DeprecatedPaintLayer.cpp

Issue 1316163002: Make the LayoutRect->FloatRect constructor explicit. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/paint/DeprecatedPaintLayer.cpp
diff --git a/Source/core/paint/DeprecatedPaintLayer.cpp b/Source/core/paint/DeprecatedPaintLayer.cpp
index 2fc1b54e4b8d38adaa1c465d049f20f56ffcf047..048c2797587a242b931b17942fc41eca588e6cec 100644
--- a/Source/core/paint/DeprecatedPaintLayer.cpp
+++ b/Source/core/paint/DeprecatedPaintLayer.cpp
@@ -1571,7 +1571,7 @@ PassRefPtr<HitTestingTransformState> DeprecatedPaintLayer::createLocalTransformS
} else {
// If this is the first time we need to make transform state, then base it off of hitTestLocation,
// which is relative to rootLayer.
- transformState = HitTestingTransformState::create(hitTestLocation.transformedPoint(), hitTestLocation.transformedRect(), FloatQuad(hitTestRect));
+ transformState = HitTestingTransformState::create(hitTestLocation.transformedPoint(), hitTestLocation.transformedRect(), FloatQuad(FloatRect(hitTestRect)));
convertToLayerCoords(rootLayer, offset);
}
offset.moveBy(translationOffset);
@@ -2175,7 +2175,8 @@ LayoutRect DeprecatedPaintLayer::boundingBoxForCompositing(const DeprecatedPaint
return LayoutRect();
LayoutRect result = clipper().localClipRect();
- if (result == LayoutRect::infiniteIntRect()) {
+ // TODO(chrishtr): avoid converting to IntRect and back.
+ if (result == LayoutRect(LayoutRect::infiniteIntRect())) {
LayoutPoint origin;
result = physicalBoundingBox(ancestorLayer, &origin);

Powered by Google App Engine
This is Rietveld 408576698