Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(781)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1316153003: Removed m_isQuirkValue and used CSSPrimitiveValue::QuirkyEms instead (Closed)

Created:
5 years, 3 months ago by sashab
Modified:
5 years, 3 months ago
Reviewers:
Timothy Loh
CC:
blink-reviews, dglazkov+blink, rwlbuis, apavlov+blink_chromium.org, blink-reviews-css, darktears, shans, esprehn, alancutter (OOO until 2018)
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Removed m_isQuirkValue and used CSSPrimitiveValue::QuirkyEms instead Removed m_isQuirkValue from CSSValue and updated callers to use CSSPrimitiveValue::UnitType::QuirkyEms instead. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201616

Patch Set 1 #

Patch Set 2 : Small fix in unitTypeToString() #

Total comments: 8

Patch Set 3 : g clt #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -22 lines) Patch
M Source/core/css/CSSPrimitiveValue.h View 1 2 4 chunks +10 lines, -15 lines 0 comments Download
M Source/core/css/CSSPrimitiveValue.cpp View 1 2 6 chunks +4 lines, -2 lines 0 comments Download
M Source/core/css/CSSValue.h View 1 2 chunks +0 lines, -2 lines 0 comments Download
M Source/core/css/parser/CSSPropertyParser.cpp View 1 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/css/resolver/StyleBuilderConverter.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (4 generated)
sashab
5 years, 3 months ago (2015-09-02 01:28:21 UTC) #2
Timothy Loh
https://codereview.chromium.org/1316153003/diff/20001/Source/core/css/CSSPrimitiveValue.cpp File Source/core/css/CSSPrimitiveValue.cpp (right): https://codereview.chromium.org/1316153003/diff/20001/Source/core/css/CSSPrimitiveValue.cpp#newcode956 Source/core/css/CSSPrimitiveValue.cpp:956: case UnitType::QuirkyEms: should still be unreachable https://codereview.chromium.org/1316153003/diff/20001/Source/core/css/CSSPrimitiveValue.h File Source/core/css/CSSPrimitiveValue.h ...
5 years, 3 months ago (2015-09-02 01:59:03 UTC) #3
sashab
https://codereview.chromium.org/1316153003/diff/20001/Source/core/css/CSSPrimitiveValue.cpp File Source/core/css/CSSPrimitiveValue.cpp (right): https://codereview.chromium.org/1316153003/diff/20001/Source/core/css/CSSPrimitiveValue.cpp#newcode956 Source/core/css/CSSPrimitiveValue.cpp:956: case UnitType::QuirkyEms: On 2015/09/02 01:59:03, Timothy Loh wrote: > ...
5 years, 3 months ago (2015-09-02 03:54:49 UTC) #4
Timothy Loh
lgtm
5 years, 3 months ago (2015-09-02 04:03:00 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1316153003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1316153003/40001
5 years, 3 months ago (2015-09-02 04:06:30 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_compile_dbg_ng/builds/93083)
5 years, 3 months ago (2015-09-02 05:16:23 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1316153003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1316153003/40001
5 years, 3 months ago (2015-09-02 05:28:06 UTC) #11
commit-bot: I haz the power
5 years, 3 months ago (2015-09-02 06:25:24 UTC) #12
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=201616

Powered by Google App Engine
This is Rietveld 408576698