Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(244)

Unified Diff: Source/core/css/parser/CSSPropertyParser.cpp

Issue 1316153003: Removed m_isQuirkValue and used CSSPrimitiveValue::QuirkyEms instead (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: g clt Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/css/CSSValue.h ('k') | Source/core/css/resolver/StyleBuilderConverter.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/css/parser/CSSPropertyParser.cpp
diff --git a/Source/core/css/parser/CSSPropertyParser.cpp b/Source/core/css/parser/CSSPropertyParser.cpp
index 97a4ff398ce4e3c4787bd9dd8998cc73717b8e48..4ddccd5395483aec08c2bc01bb68c7d3250e60ba 100644
--- a/Source/core/css/parser/CSSPropertyParser.cpp
+++ b/Source/core/css/parser/CSSPropertyParser.cpp
@@ -409,7 +409,7 @@ inline PassRefPtrWillBeRawPtr<CSSPrimitiveValue> CSSPropertyParser::parseValidPr
if (value->unit() >= CSSPrimitiveValue::UnitType::DotsPerPixel && value->unit() <= CSSPrimitiveValue::UnitType::DotsPerCentimeter)
return createPrimitiveNumericValue(value);
if (value->unit() == CSSPrimitiveValue::UnitType::QuirkyEms)
- return CSSPrimitiveValue::createAllowingMarginQuirk(value->fValue, CSSPrimitiveValue::UnitType::Ems);
+ return CSSPrimitiveValue::create(value->fValue, CSSPrimitiveValue::UnitType::QuirkyEms);
if (isCalculation(value))
return CSSPrimitiveValue::create(m_parsedCalculation.release());
@@ -7763,7 +7763,7 @@ bool CSSPropertyParser::parseSVGValue(CSSPropertyID propId, bool important)
else if (value->unit() == CSSPrimitiveValue::UnitType::Rems || value->unit() == CSSPrimitiveValue::UnitType::Chs)
parsedValue = CSSPrimitiveValue::create(value->fValue, value->unit());
else if (value->unit() == CSSPrimitiveValue::UnitType::QuirkyEms)
- parsedValue = CSSPrimitiveValue::createAllowingMarginQuirk(value->fValue, CSSPrimitiveValue::UnitType::Ems);
+ parsedValue = CSSPrimitiveValue::create(value->fValue, CSSPrimitiveValue::UnitType::QuirkyEms);
if (isCalculation(value)) {
// FIXME calc() http://webkit.org/b/16662 : actually create a CSSPrimitiveValue here, ie
// parsedValue = CSSPrimitiveValue::create(m_parsedCalculation.release());
« no previous file with comments | « Source/core/css/CSSValue.h ('k') | Source/core/css/resolver/StyleBuilderConverter.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698