Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(262)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1316143002: Fix leaks in DrawingBufferTest (Closed)

Created:
5 years, 3 months ago by dshwang
Modified:
5 years, 3 months ago
CC:
blink-reviews, krit, drott+blinkwatch_chromium.org, Rik, jbroman, Justin Novosad, danakj, pdr+graphicswatchlist_chromium.org, f(malita), Stephen Chennney, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Fix leaks in DrawingBufferTest DrawingBuffer is not deleted until all mailboxes are released. BUG=524139 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201241

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M Source/platform/graphics/gpu/DrawingBufferTest.cpp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 10 (2 generated)
dshwang
kbr: could you review? Recently chromium infrastructure found this old leaks.
5 years, 3 months ago (2015-08-26 16:32:05 UTC) #2
dshwang
On 2015/08/26 16:32:05, dshwang_ooo_5.9-27.9 wrote: > kbr: could you review? > > Recently chromium infrastructure ...
5 years, 3 months ago (2015-08-26 16:34:21 UTC) #3
bajones
On 2015/08/26 16:34:21, dshwang_ooo_5.9-27.9 wrote: > On 2015/08/26 16:32:05, dshwang_ooo_5.9-27.9 wrote: > > kbr: could ...
5 years, 3 months ago (2015-08-26 17:21:31 UTC) #4
dshwang
On 2015/08/26 17:21:31, bajones wrote: > On 2015/08/26 16:34:21, dshwang_ooo_5.9-27.9 wrote: > > On 2015/08/26 ...
5 years, 3 months ago (2015-08-26 17:27:41 UTC) #5
Nico
rs-lgtm
5 years, 3 months ago (2015-08-26 18:20:09 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1316143002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1316143002/1
5 years, 3 months ago (2015-08-26 18:24:20 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://src.chromium.org/viewvc/blink?view=rev&revision=201241
5 years, 3 months ago (2015-08-26 19:20:56 UTC) #9
Ken Russell (switch to Gerrit)
5 years, 3 months ago (2015-08-26 19:34:28 UTC) #10
Message was sent while issue was closed. 
lgtm after the fact.

Powered by Google App Engine
This is Rietveld 408576698