Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(337)

Issue 1303133002: Run Blink unit tests on the Clang ToT bots (Closed)

Created:
5 years, 4 months ago by hans
Modified:
5 years, 4 months ago
Reviewers:
Nico
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Run Blink unit tests on the Clang ToT bots These have been good indicators of miscompiles before, so let's get them on the ToT bots. BUG=452726 R=thakis@chromium.org Committed: https://chromium.googlesource.com/chromium/src/+/5974b3bc1c0b1de265566332215c67122d782a06

Patch Set 1 #

Patch Set 2 : Run on the pinned bots too #

Unified diffs Side-by-side diffs Delta from patch set Stats (+204 lines, -0 lines) Patch
M testing/buildbot/chromium.fyi.json View 1 34 chunks +204 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
hans
ptal when you're around.
5 years, 4 months ago (2015-08-21 01:18:47 UTC) #2
Nico
On 2015/08/21 01:18:47, hans wrote: > ptal when you're around. Lgtm No swarming? Should we ...
5 years, 4 months ago (2015-08-21 01:40:24 UTC) #3
hans
On 2015/08/21 01:40:24, Nico (on vacation Thu Aug 20) wrote: > On 2015/08/21 01:18:47, hans ...
5 years, 4 months ago (2015-08-21 17:42:18 UTC) #4
hans
I'll land this now, we can try swarming later.
5 years, 4 months ago (2015-08-21 17:57:39 UTC) #5
hans
5 years, 4 months ago (2015-08-21 17:59:49 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
5974b3bc1c0b1de265566332215c67122d782a06 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698