Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(100)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1316073005: Update TestPrivacySecurityPrefs to new preference. (Closed)

Created:
5 years, 3 months ago by Bence
Modified:
5 years, 3 months ago
Reviewers:
Bernhard Bauer
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update TestPrivacySecurityPrefs to new preference. Update PrefsFunctionalTest.TestPrivacySecurityPrefs to test new preference kNetworkPredictionOptions instead of deprecated preference kNetworkPredictionOptions. BUG=526773 Committed: https://crrev.com/f17f84beeab978961d5c78e03ad6aac2b00592e5 Cr-Commit-Position: refs/heads/master@{#348739}

Patch Set 1 #

Patch Set 2 : Rebase. #

Total comments: 2

Patch Set 3 : Re: #3. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -3 lines) Patch
M chrome/browser/prefs/pref_functional_browsertest.cc View 1 2 3 chunks +11 lines, -3 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
Bence
Bernhard: PTAL. Thank you.
5 years, 3 months ago (2015-09-14 18:27:23 UTC) #2
Bernhard Bauer
LGTM w/ a nit: https://codereview.chromium.org/1316073005/diff/20001/chrome/browser/prefs/pref_functional_browsertest.cc File chrome/browser/prefs/pref_functional_browsertest.cc (right): https://codereview.chromium.org/1316073005/diff/20001/chrome/browser/prefs/pref_functional_browsertest.cc#newcode208 chrome/browser/prefs/pref_functional_browsertest.cc:208: EXPECT_NE(chrome_browser_net::NETWORK_PREDICTION_DEFAULT, If this fails, something ...
5 years, 3 months ago (2015-09-14 18:52:41 UTC) #3
Bence
Thanks. https://codereview.chromium.org/1316073005/diff/20001/chrome/browser/prefs/pref_functional_browsertest.cc File chrome/browser/prefs/pref_functional_browsertest.cc (right): https://codereview.chromium.org/1316073005/diff/20001/chrome/browser/prefs/pref_functional_browsertest.cc#newcode208 chrome/browser/prefs/pref_functional_browsertest.cc:208: EXPECT_NE(chrome_browser_net::NETWORK_PREDICTION_DEFAULT, On 2015/09/14 18:52:41, Bernhard Bauer wrote: > ...
5 years, 3 months ago (2015-09-14 21:56:57 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1316073005/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1316073005/40001
5 years, 3 months ago (2015-09-14 21:58:38 UTC) #7
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 3 months ago (2015-09-14 22:13:34 UTC) #8
commit-bot: I haz the power
Patchset 3 (id:??) landed as https://crrev.com/f17f84beeab978961d5c78e03ad6aac2b00592e5 Cr-Commit-Position: refs/heads/master@{#348739}
5 years, 3 months ago (2015-09-14 22:14:23 UTC) #9
commit-bot: I haz the power
5 years, 3 months ago (2015-09-23 12:38:02 UTC) #10
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/f17f84beeab978961d5c78e03ad6aac2b00592e5
Cr-Commit-Position: refs/heads/master@{#348739}

Powered by Google App Engine
This is Rietveld 408576698