Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Side by Side Diff: chrome/browser/prefs/pref_functional_browsertest.cc

Issue 1316073005: Update TestPrivacySecurityPrefs to new preference. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Re: #3. Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include <string> 5 #include <string>
6 6
7 #include "base/strings/utf_string_conversions.h" 7 #include "base/strings/utf_string_conversions.h"
8 #include "chrome/browser/download/download_prefs.h" 8 #include "chrome/browser/download/download_prefs.h"
9 #include "chrome/browser/net/prediction_options.h"
9 #include "chrome/browser/prefs/pref_service_syncable.h" 10 #include "chrome/browser/prefs/pref_service_syncable.h"
10 #include "chrome/browser/ui/browser.h" 11 #include "chrome/browser/ui/browser.h"
11 #include "chrome/browser/ui/browser_commands.h" 12 #include "chrome/browser/ui/browser_commands.h"
12 #include "chrome/browser/ui/tabs/tab_strip_model.h" 13 #include "chrome/browser/ui/tabs/tab_strip_model.h"
13 #include "chrome/common/chrome_paths.h" 14 #include "chrome/common/chrome_paths.h"
14 #include "chrome/common/pref_names.h" 15 #include "chrome/common/pref_names.h"
15 #include "chrome/test/base/in_process_browser_test.h" 16 #include "chrome/test/base/in_process_browser_test.h"
16 #include "chrome/test/base/testing_browser_process.h" 17 #include "chrome/test/base/testing_browser_process.h"
17 #include "chrome/test/base/testing_profile.h" 18 #include "chrome/test/base/testing_profile.h"
18 #include "chrome/test/base/ui_test_utils.h" 19 #include "chrome/test/base/ui_test_utils.h"
(...skipping 178 matching lines...) Expand 10 before | Expand all | Expand 10 after
197 198
198 PrefService* prefs = browser()->profile()->GetPrefs(); 199 PrefService* prefs = browser()->profile()->GetPrefs();
199 EXPECT_FALSE(prefs->GetBoolean(prefs::kHomePageIsNewTabPage)); 200 EXPECT_FALSE(prefs->GetBoolean(prefs::kHomePageIsNewTabPage));
200 EXPECT_EQ(home_page_url.spec(), prefs->GetString(prefs::kHomePage)); 201 EXPECT_EQ(home_page_url.spec(), prefs->GetString(prefs::kHomePage));
201 } 202 }
202 203
203 // Verify the security preference under privacy across restarts. Part1 204 // Verify the security preference under privacy across restarts. Part1
204 IN_PROC_BROWSER_TEST_F(PrefsFunctionalTest, PRE_TestPrivacySecurityPrefs) { 205 IN_PROC_BROWSER_TEST_F(PrefsFunctionalTest, PRE_TestPrivacySecurityPrefs) {
205 PrefService* prefs = browser()->profile()->GetPrefs(); 206 PrefService* prefs = browser()->profile()->GetPrefs();
206 207
207 EXPECT_TRUE(prefs->GetBoolean(prefs::kNetworkPredictionEnabled)); 208 static_assert(chrome_browser_net::NETWORK_PREDICTION_DEFAULT !=
208 prefs->SetBoolean(prefs::kNetworkPredictionEnabled, false); 209 chrome_browser_net::NETWORK_PREDICTION_NEVER,
210 "PrefsFunctionalTest.TestPrivacySecurityPrefs relies on "
211 "predictive network actions being enabled by default.");
212 EXPECT_EQ(chrome_browser_net::NETWORK_PREDICTION_DEFAULT,
213 prefs->GetInteger(prefs::kNetworkPredictionOptions));
214 prefs->SetInteger(prefs::kNetworkPredictionOptions,
215 chrome_browser_net::NETWORK_PREDICTION_NEVER);
209 216
210 EXPECT_TRUE(prefs->GetBoolean(prefs::kSafeBrowsingEnabled)); 217 EXPECT_TRUE(prefs->GetBoolean(prefs::kSafeBrowsingEnabled));
211 prefs->SetBoolean(prefs::kSafeBrowsingEnabled, false); 218 prefs->SetBoolean(prefs::kSafeBrowsingEnabled, false);
212 219
213 EXPECT_TRUE(prefs->GetBoolean(prefs::kAlternateErrorPagesEnabled)); 220 EXPECT_TRUE(prefs->GetBoolean(prefs::kAlternateErrorPagesEnabled));
214 prefs->SetBoolean(prefs::kAlternateErrorPagesEnabled, false); 221 prefs->SetBoolean(prefs::kAlternateErrorPagesEnabled, false);
215 222
216 EXPECT_TRUE(prefs->GetBoolean(prefs::kSearchSuggestEnabled)); 223 EXPECT_TRUE(prefs->GetBoolean(prefs::kSearchSuggestEnabled));
217 prefs->SetBoolean(prefs::kSearchSuggestEnabled, false); 224 prefs->SetBoolean(prefs::kSearchSuggestEnabled, false);
218 } 225 }
219 226
220 // Verify the security preference under privacy across restarts. Part2 227 // Verify the security preference under privacy across restarts. Part2
221 IN_PROC_BROWSER_TEST_F(PrefsFunctionalTest, TestPrivacySecurityPrefs) { 228 IN_PROC_BROWSER_TEST_F(PrefsFunctionalTest, TestPrivacySecurityPrefs) {
222 PrefService* prefs = browser()->profile()->GetPrefs(); 229 PrefService* prefs = browser()->profile()->GetPrefs();
223 230
224 EXPECT_FALSE(prefs->GetBoolean(prefs::kNetworkPredictionEnabled)); 231 EXPECT_EQ(chrome_browser_net::NETWORK_PREDICTION_NEVER,
232 prefs->GetInteger(prefs::kNetworkPredictionOptions));
225 EXPECT_FALSE(prefs->GetBoolean(prefs::kSafeBrowsingEnabled)); 233 EXPECT_FALSE(prefs->GetBoolean(prefs::kSafeBrowsingEnabled));
226 EXPECT_FALSE(prefs->GetBoolean(prefs::kAlternateErrorPagesEnabled)); 234 EXPECT_FALSE(prefs->GetBoolean(prefs::kAlternateErrorPagesEnabled));
227 EXPECT_FALSE(prefs->GetBoolean(prefs::kSearchSuggestEnabled)); 235 EXPECT_FALSE(prefs->GetBoolean(prefs::kSearchSuggestEnabled));
228 } 236 }
229 237
230 // Verify that we have some Local State prefs. 238 // Verify that we have some Local State prefs.
231 IN_PROC_BROWSER_TEST_F(PrefsFunctionalTest, TestHaveLocalStatePrefs) { 239 IN_PROC_BROWSER_TEST_F(PrefsFunctionalTest, TestHaveLocalStatePrefs) {
232 EXPECT_TRUE(g_browser_process->local_state()->GetPreferenceValues().get()); 240 EXPECT_TRUE(g_browser_process->local_state()->GetPreferenceValues().get());
233 } 241 }
234 242
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698