Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(119)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1316033003: [DevTools] Make WebDevToolsAgentImpl own InspectorOverlayImpl. (Closed)

Created:
5 years, 3 months ago by dgozman
Modified:
5 years ago
Reviewers:
sergeyv, pfeldman
CC:
blink-reviews, caseq+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, kozyatinskiy+blink_chromium.org
Target Ref:
refs/remotes/origin/master
Project:
blink
Visibility:
Public.

Description

[DevTools] Make WebDevToolsAgentImpl own InspectorOverlayImpl. BUG=none Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201331

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -37 lines) Patch
M Source/web/WebDevToolsAgentImpl.h View 3 chunks +3 lines, -2 lines 0 comments Download
M Source/web/WebDevToolsAgentImpl.cpp View 6 chunks +8 lines, -7 lines 0 comments Download
M Source/web/WebLocalFrameImpl.h View 3 chunks +0 lines, -3 lines 0 comments Download
M Source/web/WebLocalFrameImpl.cpp View 3 chunks +0 lines, -10 lines 0 comments Download
M Source/web/WebViewImpl.h View 3 chunks +2 lines, -3 lines 0 comments Download
M Source/web/WebViewImpl.cpp View 5 chunks +14 lines, -12 lines 0 comments Download

Dependent Patchsets:

Issue 1315283002 Patch 1

Messages

Total messages: 10 (3 generated)
dgozman
Take a look please.
5 years, 3 months ago (2015-08-27 01:18:31 UTC) #2
sergeyv
lgtm
5 years, 3 months ago (2015-08-27 17:51:17 UTC) #4
pfeldman
lgtm
5 years, 3 months ago (2015-08-27 17:53:41 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1316033003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1316033003/1
5 years, 3 months ago (2015-08-27 18:13:16 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://src.chromium.org/viewvc/blink?view=rev&revision=201331
5 years, 3 months ago (2015-08-27 19:36:40 UTC) #8
Charlie Reis
On 2015/08/27 19:36:40, commit-bot: I haz the power wrote: > Committed patchset #1 (id:1) as ...
5 years, 3 months ago (2015-08-28 17:24:24 UTC) #9
dgozman
5 years, 3 months ago (2015-08-28 18:23:02 UTC) #10
Message was sent while issue was closed. 
On 2015/08/28 17:24:24, Charlie Reis wrote:
> On 2015/08/27 19:36:40, commit-bot: I haz the power wrote:
> > Committed patchset #1 (id:1) as
> > https://src.chromium.org/viewvc/blink?view=rev&revision=201331
> 
> This CL seems to have caused a regression on the Site Isolation FYI bots.  See
> https://crbug.com/526162.  Can it be fixed/reverted/disabled there?

I'll take a look today.

Powered by Google App Engine
This is Rietveld 408576698