Source/core/paint/FieldsetPainter.cpp - Issue 1315993004: Implement a paint offset cache for slimming paint v2

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/paint/FieldsetPainter.cpp

Issue 1315993004: Implement a paint offset cache for slimming paint v2 (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/core/paint/BlockFlowPainter.cpp ('K') | « Source/core/paint/EmbeddedObjectPainter.cpp ('k') | Source/core/paint/FileUploadControlPainter.cpp » ('j') | Source/platform/graphics/paint/DisplayItemList.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/paint/FieldsetPainter.cpp

diff --git a/Source/core/paint/FieldsetPainter.cpp b/Source/core/paint/FieldsetPainter.cpp

index fcbdf8b16b33274fda85ac212f99580a860c9d4e..8c2b20b4b3eae5af03cae4701850ef0b96fc53c2 100644

--- a/Source/core/paint/FieldsetPainter.cpp

+++ b/Source/core/paint/FieldsetPainter.cpp

@@ -24,7 +24,7 @@ void FieldsetPainter::paintBoxDecorationBackground(const PaintInfo& paintInfo, c

if (!legend)

return BoxPainter(m_layoutFieldset).paintBoxDecorationBackground(paintInfo, paintOffset);

- if (LayoutObjectDrawingRecorder::useCachedDrawingIfPossible(*paintInfo.context, m_layoutFieldset, paintInfo.phase))

+ if (LayoutObjectDrawingRecorder::useCachedDrawingIfPossible(*paintInfo.context, m_layoutFieldset, paintInfo.phase, paintOffset))

return;

// FIXME: We need to work with "rl" and "bt" block flow directions. In those

@@ -40,7 +40,7 @@ void FieldsetPainter::paintBoxDecorationBackground(const PaintInfo& paintInfo, c

paintRect.setX(paintRect.x() + xOff);

}

- LayoutObjectDrawingRecorder recorder(*paintInfo.context, m_layoutFieldset, paintInfo.phase, pixelSnappedIntRect(paintRect));

+ LayoutObjectDrawingRecorder recorder(*paintInfo.context, m_layoutFieldset, paintInfo.phase, pixelSnappedIntRect(paintRect), paintOffset);

BoxDecorationData boxDecorationData(m_layoutFieldset);

if (boxDecorationData.bleedAvoidance == BackgroundBleedNone)

@@ -81,7 +81,7 @@ void FieldsetPainter::paintMask(const PaintInfo& paintInfo, const LayoutPoint& p

if (!legend)

return BoxPainter(m_layoutFieldset).paintMask(paintInfo, paintOffset);

- if (LayoutObjectDrawingRecorder::useCachedDrawingIfPossible(*paintInfo.context, m_layoutFieldset, paintInfo.phase))

+ if (LayoutObjectDrawingRecorder::useCachedDrawingIfPossible(*paintInfo.context, m_layoutFieldset, paintInfo.phase, paintOffset))

return;

// FIXME: We need to work with "rl" and "bt" block flow directions. In those

@@ -97,7 +97,7 @@ void FieldsetPainter::paintMask(const PaintInfo& paintInfo, const LayoutPoint& p

paintRect.move(xOff, 0);

}

- LayoutObjectDrawingRecorder recorder(*paintInfo.context, m_layoutFieldset, paintInfo.phase, paintRect);

+ LayoutObjectDrawingRecorder recorder(*paintInfo.context, m_layoutFieldset, paintInfo.phase, paintRect, paintOffset);

BoxPainter(m_layoutFieldset).paintMaskImages(paintInfo, paintRect);

}