Source/core/paint/EmbeddedObjectPainter.cpp - Issue 1315993004: Implement a paint offset cache for slimming paint v2

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/paint/EmbeddedObjectPainter.cpp

Issue 1315993004: Implement a paint offset cache for slimming paint v2 (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/core/paint/BlockFlowPainter.cpp ('K') | « Source/core/paint/DetailsMarkerPainter.cpp ('k') | Source/core/paint/FieldsetPainter.cpp » ('j') | Source/platform/graphics/paint/DisplayItemList.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/paint/EmbeddedObjectPainter.cpp

diff --git a/Source/core/paint/EmbeddedObjectPainter.cpp b/Source/core/paint/EmbeddedObjectPainter.cpp

index 8dd5c5bc11ca175a8a1fe3f24088692756a54064..6b1bb18d5bd72685bcd52fa484e53e25f47c6ae3 100644

--- a/Source/core/paint/EmbeddedObjectPainter.cpp

+++ b/Source/core/paint/EmbeddedObjectPainter.cpp

@@ -44,12 +44,12 @@ void EmbeddedObjectPainter::paintReplaced(const PaintInfo& paintInfo, const Layo

return;

GraphicsContext* context = paintInfo.context;

- if (LayoutObjectDrawingRecorder::useCachedDrawingIfPossible(*context, m_layoutEmbeddedObject, paintInfo.phase))

+ if (LayoutObjectDrawingRecorder::useCachedDrawingIfPossible(*context, m_layoutEmbeddedObject, paintInfo.phase, paintOffset))

return;

FloatRect contentRect = m_layoutEmbeddedObject.contentBoxRect();

contentRect.moveBy(roundedIntPoint(paintOffset));

- LayoutObjectDrawingRecorder drawingRecorder(*context, m_layoutEmbeddedObject, paintInfo.phase, contentRect);

+ LayoutObjectDrawingRecorder drawingRecorder(*context, m_layoutEmbeddedObject, paintInfo.phase, contentRect, paintOffset);

GraphicsContextStateSaver stateSaver(*context);

context->clip(contentRect);