Issue 1315983012: Drop getBBox() override on SVGPathElement

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1315983012: Drop getBBox() override on SVGPathElement (Closed)

Created:
5 years, 3 months ago by fs

Modified:
5 years, 3 months ago

Reviewers:
pdr., f(malita)

CC:
blink-reviews, krit, f(malita), fs, gyuyoung2, kouhei+svg_chromium.org, pdr+svgwatchlist_chromium.org, rwlbuis, Stephen Chennney

Base URL:
svn://svn.chromium.org/blink/trunk

Target Ref:
refs/heads/master

Project:
blink

Visibility:
Public.

More Reviews

Description

Drop getBBox() override on SVGPathElement path().boundingRect() is exactly what objectBoundingBox() will return for LayoutSVGPath, so the implementation from SVGGraphicElement can be used. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201917

Patch Set 1 #

Created: 5 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -17 lines)			Patch
	M	Source/core/svg/SVGPathElement.h	View		1 chunk	+0 lines, -2 lines	0 comments	Download
	M	Source/core/svg/SVGPathElement.cpp	View		1 chunk	+0 lines, -15 lines	0 comments	Download

Messages

Total messages: 6 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1315983012/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1315983012/1

5 years, 3 months ago (2015-09-08 15:37:57 UTC) #5

commit-bot: I haz the power

5 years, 3 months ago (2015-09-08 16:11:58 UTC) #6

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=201917

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages