Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(172)

Side by Side Diff: Source/core/svg/SVGPathElement.cpp

Issue 1315983012: Drop getBBox() override on SVGPathElement (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « Source/core/svg/SVGPathElement.h ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2004, 2005, 2006, 2008 Nikolas Zimmermann <zimmermann@kde.org> 2 * Copyright (C) 2004, 2005, 2006, 2008 Nikolas Zimmermann <zimmermann@kde.org>
3 * Copyright (C) 2004, 2005, 2006, 2007 Rob Buis <buis@kde.org> 3 * Copyright (C) 2004, 2005, 2006, 2007 Rob Buis <buis@kde.org>
4 * 4 *
5 * This library is free software; you can redistribute it and/or 5 * This library is free software; you can redistribute it and/or
6 * modify it under the terms of the GNU Library General Public 6 * modify it under the terms of the GNU Library General Public
7 * License as published by the Free Software Foundation; either 7 * License as published by the Free Software Foundation; either
8 * version 2 of the License, or (at your option) any later version. 8 * version 2 of the License, or (at your option) any later version.
9 * 9 *
10 * This library is distributed in the hope that it will be useful, 10 * This library is distributed in the hope that it will be useful,
(...skipping 252 matching lines...) Expand 10 before | Expand all | Expand 10 after
263 263
264 SVGElement::InvalidationGuard invalidationGuard(this); 264 SVGElement::InvalidationGuard invalidationGuard(this);
265 LayoutSVGShape* layoutObject = toLayoutSVGShape(this->layoutObject()); 265 LayoutSVGShape* layoutObject = toLayoutSVGShape(this->layoutObject());
266 if (!layoutObject) 266 if (!layoutObject)
267 return; 267 return;
268 268
269 layoutObject->setNeedsShapeUpdate(); 269 layoutObject->setNeedsShapeUpdate();
270 markForLayoutAndParentResourceInvalidation(layoutObject); 270 markForLayoutAndParentResourceInvalidation(layoutObject);
271 } 271 }
272 272
273 FloatRect SVGPathElement::getBBox()
274 {
275 // By default, getBBox() returns objectBoundingBox but that will include
276 // markers so we override it to return just the path's bounding rect.
277
278 document().updateLayoutIgnorePendingStylesheets();
279
280 // FIXME: Eventually we should support getBBox for detached elements.
281 if (!layoutObject())
282 return FloatRect();
283
284 LayoutSVGShape* layoutObject = toLayoutSVGShape(this->layoutObject());
285 return layoutObject->path().boundingRect();
286 }
287
288 } // namespace blink 273 } // namespace blink
OLDNEW
« no previous file with comments | « Source/core/svg/SVGPathElement.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698