Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(234)

Issue 1315923004: Convert child FPs from refs to pending executions when parent converts (Closed)

Created:
5 years, 3 months ago by bsalomon
Modified:
5 years, 3 months ago
Reviewers:
wangyix, robertphillips
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Convert child FPs from refs to pending executions when parent converts Committed: https://skia.googlesource.com/skia/+/4204800cd8f311f11491cf2eb7e32ca681f05489

Patch Set 1 #

Patch Set 2 : make notifyRefCntIsZero const and remove need for bool in GrFP #

Patch Set 3 : working #

Total comments: 1

Patch Set 4 : Update comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+49 lines, -11 lines) Patch
M include/gpu/GrFragmentProcessor.h View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M include/gpu/GrProgramElement.h View 1 2 3 4 chunks +33 lines, -10 lines 0 comments Download
M include/gpu/GrXferProcessor.h View 1 1 chunk +2 lines, -0 lines 0 comments Download
M src/gpu/GrPrimitiveProcessor.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M src/gpu/GrProcessor.cpp View 1 2 3 2 chunks +11 lines, -1 line 0 comments Download

Messages

Total messages: 14 (5 generated)
bsalomon
This allows GPU resources owned by child processors to be recycled once the parent processor ...
5 years, 3 months ago (2015-08-27 18:46:48 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1315923004/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1315923004/40001
5 years, 3 months ago (2015-08-27 18:47:06 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 3 months ago (2015-08-27 18:52:07 UTC) #6
robertphillips
lgtm + dox request https://codereview.chromium.org/1315923004/diff/40001/include/gpu/GrProgramElement.h File include/gpu/GrProgramElement.h (right): https://codereview.chromium.org/1315923004/diff/40001/include/gpu/GrProgramElement.h#newcode24 include/gpu/GrProgramElement.h:24: * when the program element ...
5 years, 3 months ago (2015-08-27 19:39:06 UTC) #7
robertphillips
I've created https://code.google.com/p/skia/issues/detail?id=4263 to, hopefully, capture some thoughts on preventing hard refs from intruding into ...
5 years, 3 months ago (2015-08-27 19:45:23 UTC) #8
bsalomon
On 2015/08/27 19:45:23, robertphillips wrote: > I've created https://code.google.com/p/skia/issues/detail?id=4263 to, hopefully, > capture some thoughts ...
5 years, 3 months ago (2015-08-27 20:02:49 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1315923004/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1315923004/60001
5 years, 3 months ago (2015-08-27 23:04:13 UTC) #12
commit-bot: I haz the power
Committed patchset #4 (id:60001) as https://skia.googlesource.com/skia/+/4204800cd8f311f11491cf2eb7e32ca681f05489
5 years, 3 months ago (2015-08-27 23:43:51 UTC) #13
robertphillips
5 years, 3 months ago (2015-08-28 12:36:55 UTC) #14
Message was sent while issue was closed.
The comment looks good.

Powered by Google App Engine
This is Rietveld 408576698