Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(111)

Issue 13159005: Enable media stream layout test with content_shell. (Closed)

Created:
7 years, 8 months ago by wjia(left Chromium)
Modified:
7 years, 8 months ago
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, jochen+watch_chromium.org
Visibility:
Public.

Description

Enable media stream layout test with content_shell. When using content_shell to run media stream layout test, it's needed to use override createMediaPlayer because the media stream is generated by TestMediaStreamClient, not MediaStreamImpl which is used by RenderViewImpl::createMediaPlayer. This patch is needed by patch in https://bugs.webkit.org/show_bug.cgi?id=113633, and they work together to enable media stream layout test in content_shell. BUG=222906 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=192373

Patch Set 1 #

Patch Set 2 : #

Total comments: 4

Patch Set 3 : code review #

Total comments: 2

Patch Set 4 : #

Patch Set 5 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+95 lines, -8 lines) Patch
M content/shell/webkit_test_runner.h View 1 2 3 4 chunks +12 lines, -0 lines 0 comments Download
M content/shell/webkit_test_runner.cc View 1 2 3 4 3 chunks +14 lines, -0 lines 0 comments Download
A webkit/mocks/DEPS View 1 2 1 chunk +3 lines, -0 lines 0 comments Download
A + webkit/mocks/test_media_stream_client.h View 1 2 2 chunks +19 lines, -5 lines 0 comments Download
A + webkit/mocks/test_media_stream_client.cc View 1 2 3 5 chunks +38 lines, -3 lines 0 comments Download
M webkit/support/test_media_stream_client.h View 1 2 3 1 chunk +4 lines, -0 lines 0 comments Download
M webkit/support/webkit_support.h View 1 2 3 1 chunk +3 lines, -0 lines 0 comments Download
M webkit/support/webkit_support.gypi View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
wjia(left Chromium)
PTAL this patch and https://bugs.webkit.org/show_bug.cgi?id=113633.
7 years, 8 months ago (2013-04-02 02:43:50 UTC) #1
jochen (gone - plz use gerrit)
https://codereview.chromium.org/13159005/diff/19002/content/shell/webkit_test_runner.cc File content/shell/webkit_test_runner.cc (right): https://codereview.chromium.org/13159005/diff/19002/content/shell/webkit_test_runner.cc#newcode62 content/shell/webkit_test_runner.cc:62: #include "webkit/support/webkit_support.h" content/ must not depend on webkit/support. You ...
7 years, 8 months ago (2013-04-02 07:02:20 UTC) #2
wjia(left Chromium)
ptal. I will update WebKit patch. This patch should land before the WebKit patch. There ...
7 years, 8 months ago (2013-04-03 00:44:04 UTC) #3
jochen (gone - plz use gerrit)
lgtm https://codereview.chromium.org/13159005/diff/24001/content/shell/webkit_test_runner.cc File content/shell/webkit_test_runner.cc (right): https://codereview.chromium.org/13159005/diff/24001/content/shell/webkit_test_runner.cc#newcode498 content/shell/webkit_test_runner.cc:498: if (!test_media_stream_client_.get()) nit. { } required for multi-line ...
7 years, 8 months ago (2013-04-03 07:18:58 UTC) #4
wjia(left Chromium)
+jamesr@ for owner stamp on webkit/ https://codereview.chromium.org/13159005/diff/24001/content/shell/webkit_test_runner.cc File content/shell/webkit_test_runner.cc (right): https://codereview.chromium.org/13159005/diff/24001/content/shell/webkit_test_runner.cc#newcode498 content/shell/webkit_test_runner.cc:498: if (!test_media_stream_client_.get()) On ...
7 years, 8 months ago (2013-04-04 14:21:51 UTC) #5
jamesr
webkit/ lgtm
7 years, 8 months ago (2013-04-04 17:56:15 UTC) #6
wjia(left Chromium)
7 years, 8 months ago (2013-04-04 18:25:27 UTC) #7
Message was sent while issue was closed.
Committed patchset #5 manually as r192373 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698