build/android/buildbot/bb_utils.py - Issue 1315743004: [Android] Add a custom pylintrc for build/android/.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/android/buildbot/bb_utils.py

Issue 1315743004: [Android] Add a custom pylintrc for build/android/. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« build/android/buildbot/bb_device_steps.py ('K') | « build/android/buildbot/bb_device_steps.py ('k') | build/android/devil/android/apk_helper.py » ('j') | build/android/devil/android/decorators.py » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: build/android/buildbot/bb_utils.py

diff --git a/build/android/buildbot/bb_utils.py b/build/android/buildbot/bb_utils.py

index 3c16cc2bc5b243d4db1c7b1eeb8f3c5a948862c1..969655f520e095d7a268c9ecba34073bde1cee9f 100644

--- a/build/android/buildbot/bb_utils.py

+++ b/build/android/buildbot/bb_utils.py

@@ -33,7 +33,7 @@ GSUTIL_PATH = os.path.join(BB_BUILD_DIR, 'third_party', 'gsutil', 'gsutil')

def CommandToString(command):

"""Returns quoted command that can be run in bash shell."""

- return ' '.join(map(pipes.quote, command))

+ return ' '.join(pipes.quote(c) for c in command)

perezju 2015/09/04 09:01:53 maybe cmd_helper.SingleQuote?

jbudorick 2015/09/04 16:51:55 done

def SpawnCmd(command, stdout=None, cwd=CHROME_SRC):